Skip to content

OCPBUGS-55047: align spacing after breadrcumb with PatternFly #14972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

OCPBUGS-55047: align spacing after breadrcumb with PatternFly #14972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions frontend/public/components/monitoring/_monitoring.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@
}
}

.monitoring-breadcrumbs {
padding-bottom: var(--pf-t--global--spacer--sm);
}

.monitoring-dashboards__card {
height: calc(100% - 20px);
margin: 0 0 20px 0;
Expand Down Expand Up @@ -582,7 +578,8 @@ $monitoring-line-height: 18px;
}

.query-browser__wrapper {
border: var(--pf-t--global--border--width--regular) solid var(--pf-t--global--border--color--default);
border: var(--pf-t--global--border--width--regular) solid
var(--pf-t--global--border--color--default);
margin: 0 0 20px 0;
overflow: visible;
padding: 10px;
Expand Down
4 changes: 2 additions & 2 deletions frontend/public/components/monitoring/alertmanager/alertmanager-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ export const AlertmanagerConfig: React.FC = () => {
return (
<>
<PageBreadcrumb>
<Breadcrumb className="monitoring-breadcrumbs">
<Breadcrumb>
<BreadcrumbItem>
<Link className="pf-v6-c-breadcrumb__link" to={breadcrumbs[0].path}>
{breadcrumbs[0].name}
Expand All @@ -561,7 +561,7 @@ export const AlertmanagerConfig: React.FC = () => {
<BreadcrumbItem isActive>{breadcrumbs[1].name}</BreadcrumbItem>
</Breadcrumb>
</PageBreadcrumb>
<NavTitle className="co-m-nav-title--detail co-m-nav-title--breadcrumbs">
<NavTitle className="co-m-nav-title--detail">
<PrimaryHeading>
<div className="co-m-pane__name co-resource-item">
<span className="co-resource-item__resource-name" data-test-id="resource-title">
Expand Down
4 changes: 2 additions & 2 deletions frontend/public/components/monitoring/alertmanager/alertmanager-yaml-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const AlertmanagerYAML: React.FC<{}> = () => {
return (
<>
<PageBreadcrumb>
<Breadcrumb className="monitoring-breadcrumbs">
<Breadcrumb>
<BreadcrumbItem>
<Link className="pf-v6-c-breadcrumb__link" to={breadcrumbs[0].path}>
{breadcrumbs[0].name}
Expand All @@ -138,7 +138,7 @@ const AlertmanagerYAML: React.FC<{}> = () => {
<BreadcrumbItem isActive>{breadcrumbs[1].name}</BreadcrumbItem>
</Breadcrumb>
</PageBreadcrumb>
<NavTitle className="co-m-nav-title--detail co-m-nav-title--breadcrumbs">
<NavTitle className="co-m-nav-title--detail">
<PrimaryHeading>
<div className="co-m-pane__name co-resource-item">
<span className="co-resource-item__resource-name" data-test-id="resource-title">
Expand Down
6 changes: 1 addition & 5 deletions frontend/public/components/utils/headings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,7 @@ export const PageHeading = connectToModel((props: PageHeadingProps) => {
)}
<NavTitle
data-test-id={dataTestId}
className={classNames(
{ 'co-m-nav-title--breadcrumbs': showBreadcrumbs },
{ 'co-m-nav-title--row': navTitleAsRow },
className,
)}
className={classNames({ 'co-m-nav-title--row': navTitleAsRow }, className)}
style={style}
>
{showHeading && (
Expand Down