OCPBUGS-56379: Custom masthead logo doesn't work with a specific kiwi graphic

[Mylanos]

Using PF defaults for masthead logo max width CSS styling fixes a problem, where certain logos were not displaying at all (this kiwi logo for example). The custom logo images rendered within the Brand component scale well even without these overrides (even though the logos appear to be a bit smaller), the static logos appearance within ReactSVG component remained the same as well.

before (custom logo - kiwi):

after(kiwi):

before (custom logo - banana):

after (custom logo - banana):

[openshift-ci-robot]

@Mylanos: This pull request references Jira Issue OCPBUGS-56379, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Using PF defaults for masthead logo max width CSS styling fixes a problem, where certain logos were not displaying at all (this kiwi logo for example). The custom logo images rendered within the Brand component scale well even without these overrides (even though the logos appear to be a bit smaller), the static logos appearance within ReactSVG component remained the same as well.

before (custom logo - kiwi):

after(kiwi):

before (custom logo - banana):

after (custom logo - banana):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/public/style/OWNERS [Mylanos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Mylanos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	d98ac95	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rhamilto]

@Mylanos, let's discuss at scrum.

• Docs state we restrict the logo height to a max of 60px. We've had a customer bug in the past without this restriction because we've always had it and and an existing oversized logo will make the masthead grow in an undesirable way when upgrading to a version without the restriction.
• This fix results in an issue with three line logos (see screenshots below).

[rhamilto]

/hold