Skip to content

OCPBUGS-56379: Custom masthead logo doesn't work with a specific kiwi graphic #15088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-56379: Custom masthead logo doesn't work with a specific kiwi graphic #15088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions frontend/public/style/_overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

// Use this file to override styles from 3rd party dependencies

$masthead-logo-max-height: 60px;

// TODO: Remove when upgrading to PF 6.3.0: https://github.com/patternfly/patternfly/pull/7420
.catalog-tile-pf-title {
@include co-break-word;
Expand Down Expand Up @@ -178,15 +176,6 @@ $masthead-logo-max-height: 60px;
height: 100%;
}

.pf-v6-c-masthead {
--pf-v6-c-masthead__logo--MaxHeight: $masthead-logo-max-height; // so that logos with three lines of text fit
}

.pf-v6-c-masthead__logo {
--pf-v6-c-masthead__logo--MaxHeight: #{$masthead-logo-max-height}; // Restore the max-height from PageHeader to maintain backwards compatibility
--pf-v6-c-masthead__logo--Width: auto; // Do not set a width to maintain backwards compatibility
}

// PF components that calculate their correct height based on --pf-t--global--font--size--md: 1rem
.pf-v6-c-modal-box,
.pf-v6-c-switch {
Expand Down