OCPBUGS-42220: Infoblox - use 2.12.2 WAPI version #229

alebedev87 · 2024-09-03T22:03:17Z

This PR aims at updating the nominal version of Infoblox's WAPI we test our operator against. The test Infoblox instance we use is recommended to be used with 2.12.2 WAPI version (Infoblox ref).

alebedev87 · 2024-09-05T14:45:41Z

/retest

Job execution failed: Pod scheduling timeout.

The test NIOS instance has been upgraded to 8.6.4 which recommends 2.12.2 as the WAPI version. This commit updates the e2e test and docs with the recommended WAPI version. Ref: https://community.infoblox.com/cixhp49439/attachments/cixhp49439/IPAM/6153/2/NIOS_8.6.2_ReleaseNotesREVC.pdf

openshift-ci-robot · 2024-10-07T11:19:06Z

@alebedev87: This pull request references Jira Issue OCPBUGS-42220, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-10-07T11:19:51Z

/jira refresh

openshift-ci-robot · 2024-10-07T11:19:59Z

@alebedev87: This pull request references Jira Issue OCPBUGS-42220, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Miciah · 2024-10-07T23:54:11Z

test/e2e/infoblox.go

+	// https://community.infoblox.com/cixhp49439/attachments/cixhp49439/IPAM/6153/2/NIOS_8.6.2_ReleaseNotesREVC.pdf
+	// Chapter: "Changes to Infoblox API and Restful API (WAPI)"
+	// "2.12.2" version is recommended for NIOS 8.6.2 (our Infoblox test instance is currently 8.6.4).
+	defaultWAPIVersion            = "2.12.2"


Could this break compatibility with NIOS 7? We might need to add an API field to specify the WAPI version.

Ah, I see that it is configurable:

external-dns-operator/api/v1beta1/externaldns_types.go

Lines 367 to 371 in 57a58f8

// WAPIVersion is the version of the Infoblox WAPI.

//

// +kubebuilder:validation:Required

// +required

WAPIVersion string `json:"wapiVersion"`

Could this break compatibility with NIOS 7?

Not really, this is just the nominal version of the API we test our operator against. As you mentioned the user has to provide its version as a dedicated API field.

openshift-ci-robot · 2024-10-08T15:08:06Z

@alebedev87: This pull request references Jira Issue OCPBUGS-42220, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

This PR aims at updating the nominal version of Infoblox's WAPI we test our operator against. The test Infoblox instance we use is recommended to be used with 2.12.2 WAPI version (Infoblox ref).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-10-08T15:13:00Z

After a bug scrub discussion:

We think that https://issues.redhat.com//browse/OCPBUGS-42220 can be fixed by a simple doc update. A placeholder can be used for the wapi version in the docs.
The API doc needs to be updated to specify valid versions. And may be a validation webhook needs to updated to make sure the provided version is valid.
This PR pursues yet an other goal - update the nominal wapi version we test against.

melvinjoseph86 · 2024-10-09T02:29:55Z

this PR cannot be test using pre-merge verification method as external-dns-operator repo is still not supported in clusterbot

melvinjoseph86 · 2024-10-23T11:55:24Z

/retest

alebedev87 · 2024-10-25T10:04:58Z

xref: openshift/openshift-docs#83270

melvinjoseph86 · 2024-11-06T00:52:36Z

Pre merged verified using cluster bot

mjoseph@mjoseph-mac Downloads % oc get clusterversion                                                              
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.17.0-0.ci.test-2024-11-05-145258-ci-ln-nv2gvht-latest   True        False         69m     Cluster version is 4.17.0-0.ci.test-2024-11-05-145258-ci-ln-nv2gvht-latest

mjoseph@mjoseph-mac Downloads % oc get po -n external-dns-operator                                                 
NAME                                                              READY   STATUS      RESTARTS   AGE
external-dns-operator-76bfd77657-zvqdq                            2/2     Running     0          65m
external-dns-sample-aws-545c65987d-p62hp                          1/1     Running     0          32s
mjoseph@mjoseph-mac Downloads % oc get po -n  external-dns-operator external-dns-operator-76bfd77657-zvqdq   -oyaml
apiVersion: v1
kind: Pod
metadata:
  annotations:
    alm-examples: |-
<-----snip---->
        {
          "apiVersion": "externaldns.olm.openshift.io/v1alpha1",
          "kind": "ExternalDNS",
          "metadata": {
            "name": "sample-infoblox"
          },
          "spec": {
            "domains": [
              {
                "filterType": "Include",
                "matchType": "Exact",
                "name": "myzonedomain.com"
              }
            ],
            "provider": {
              "infoblox": {
                "credentials": {
                  "name": "infoblox-credentials"
                },
                "gridHost": "100.100.100.100",
                "wapiPort": 443,
                "wapiVersion": "2.12.2". <-----------
              },
              "type": "Infoblox"
            },
            "source": {
              "openshiftRouteOptions": {
                "routerName": "default"
              },
              "type": "OpenShiftRoute"
            }
          }
        },
<-----snip---->
          "apiVersion": "externaldns.olm.openshift.io/v1beta1",
          "kind": "ExternalDNS",
          "metadata": {
            "name": "sample-infoblox"
          },
          "spec": {
            "domains": [
              {
                "filterType": "Include",
                "matchType": "Exact",
                "name": "myzonedomain.com"
              }
            ],
            "provider": {
              "infoblox": {
                "credentials": {
                  "name": "infoblox-credentials"
                },
                "gridHost": "100.100.100.100",
                "wapiPort": 443,
                "wapiVersion": "2.12.2".    <----------------------
              },
              "type": "Infoblox"
            },
            "source": {
              "openshiftRouteOptions": {
                "routerName": "default"
              },
              "type": "OpenShiftRoute"
            }
          }
        }
      ]
<-----snip---->

melvinjoseph86 · 2024-11-06T00:52:59Z

/label qe-approved

Miciah · 2024-11-27T16:48:56Z

/assign

candita · 2024-11-27T17:17:53Z

/assign @Miciah
/assign

candita · 2025-01-13T22:08:03Z

@alebedev87 is this supposed to be on hold? I was going to LGTM, but once it comes off hold that will be removed.

alebedev87 · 2025-01-15T14:15:42Z

@candita : No. The only related thing is the doc PR but one does not block another.

candita · 2025-01-16T20:15:44Z

/lgtm

alebedev87 · 2025-01-20T13:37:31Z

/approve

openshift-ci · 2025-01-20T13:38:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-01-20T16:09:47Z

/retest-required

Remaining retests: 0 against base HEAD 1f90625 and 2 for PR HEAD 57a58f8 in total

openshift-ci · 2025-01-20T18:03:36Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-01-20T18:07:03Z

@alebedev87: Jira Issue OCPBUGS-42220: All pull requests linked via external trackers have merged:

openshift/external-dns-operator#229

Jira Issue OCPBUGS-42220 has been moved to the MODIFIED state.

In response to this:

This PR aims at updating the nominal version of Infoblox's WAPI we test our operator against. The test Infoblox instance we use is recommended to be used with 2.12.2 WAPI version (Infoblox ref).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2024

openshift-ci bot requested review from candita and gcs278 September 3, 2024 22:03

alebedev87 changed the title ~~[WIP] e2e: Infoblox - use 2.9.1 WAPI version~~ e2e: Infoblox - use 2.9.1 WAPI version Sep 5, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024

alebedev87 force-pushed the test-wapi-2-9-1 branch from cdd21e0 to 1223734 Compare September 5, 2024 09:31

alebedev87 changed the title ~~e2e: Infoblox - use 2.9.1 WAPI version~~ e2e: Infoblox - use 2.12.2 WAPI version Sep 5, 2024

alebedev87 force-pushed the test-wapi-2-9-1 branch from 1223734 to b6b8781 Compare September 5, 2024 12:04

alebedev87 force-pushed the test-wapi-2-9-1 branch from b6b8781 to 57a58f8 Compare October 7, 2024 11:18

alebedev87 changed the title ~~e2e: Infoblox - use 2.12.2 WAPI version~~ OCPBUGS-42220: Infoblox - use 2.12.2 WAPI version Oct 7, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 7, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 7, 2024

openshift-ci bot requested a review from melvinjoseph86 October 7, 2024 11:20

Miciah reviewed Oct 7, 2024

View reviewed changes

ankhande mentioned this pull request Oct 8, 2024

Update list of all supported wapiVersions in External DNS Operator Documentation openshift/openshift-docs#83223

Closed

ankhande mentioned this pull request Oct 9, 2024

Update list of all supported wapiVersions in External DNS Operator Documentation openshift/openshift-docs#83270

Open

1 task

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 6, 2024

Miciah added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 13, 2024

openshift-ci bot assigned Miciah Nov 27, 2024

openshift-ci bot assigned candita Nov 27, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025

openshift-merge-bot bot merged commit 39c5d56 into openshift:main Jan 20, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-42220: Infoblox - use 2.12.2 WAPI version #229

OCPBUGS-42220: Infoblox - use 2.12.2 WAPI version #229

alebedev87 commented Sep 3, 2024 •

edited

Loading

alebedev87 commented Sep 5, 2024

openshift-ci-robot commented Oct 7, 2024

alebedev87 commented Oct 7, 2024

openshift-ci-robot commented Oct 7, 2024

Miciah Oct 7, 2024

Miciah Oct 8, 2024

alebedev87 Oct 8, 2024

openshift-ci-robot commented Oct 8, 2024

alebedev87 commented Oct 8, 2024

melvinjoseph86 commented Oct 9, 2024

melvinjoseph86 commented Oct 23, 2024

alebedev87 commented Oct 25, 2024

melvinjoseph86 commented Nov 6, 2024

melvinjoseph86 commented Nov 6, 2024

Miciah commented Nov 27, 2024

candita commented Nov 27, 2024

candita commented Jan 13, 2025

alebedev87 commented Jan 15, 2025

candita commented Jan 16, 2025

alebedev87 commented Jan 20, 2025

openshift-ci bot commented Jan 20, 2025

openshift-ci-robot commented Jan 20, 2025

openshift-ci bot commented Jan 20, 2025

openshift-ci-robot commented Jan 20, 2025

	// WAPIVersion is the version of the Infoblox WAPI.
	//
	// +kubebuilder:validation:Required
	// +required
	WAPIVersion string `json:"wapiVersion"`

OCPBUGS-42220: Infoblox - use 2.12.2 WAPI version #229

OCPBUGS-42220: Infoblox - use 2.12.2 WAPI version #229

Conversation

alebedev87 commented Sep 3, 2024 • edited Loading

alebedev87 commented Sep 5, 2024

openshift-ci-robot commented Oct 7, 2024

alebedev87 commented Oct 7, 2024

openshift-ci-robot commented Oct 7, 2024

Miciah Oct 7, 2024

Choose a reason for hiding this comment

Miciah Oct 8, 2024

Choose a reason for hiding this comment

alebedev87 Oct 8, 2024

Choose a reason for hiding this comment

openshift-ci-robot commented Oct 8, 2024

alebedev87 commented Oct 8, 2024

melvinjoseph86 commented Oct 9, 2024

melvinjoseph86 commented Oct 23, 2024

alebedev87 commented Oct 25, 2024

melvinjoseph86 commented Nov 6, 2024

melvinjoseph86 commented Nov 6, 2024

Miciah commented Nov 27, 2024

candita commented Nov 27, 2024

candita commented Jan 13, 2025

alebedev87 commented Jan 15, 2025

candita commented Jan 16, 2025

alebedev87 commented Jan 20, 2025

openshift-ci bot commented Jan 20, 2025

openshift-ci-robot commented Jan 20, 2025

openshift-ci bot commented Jan 20, 2025

openshift-ci-robot commented Jan 20, 2025

alebedev87 commented Sep 3, 2024 •

edited

Loading