-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update list of all supported wapiVersions in External DNS Operator Documentation #83270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/label peer-review-in-progress |
@ankhande: Can not set label peer-review-in-progress: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @ankhande. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label peer-review-in-progress |
/ok-to-test |
🤖 Fri Oct 25 02:02:23 - Prow CI generated the docs preview: |
@melvinjoseph86 PTAL, thanks |
/label qe-approved |
/label merge-review-needed |
@ankhande: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label merge-review-needed |
Hi, this did not have a peer review by the OpenShift docs team. It needs one before it can be merged. I will do that peer review. |
modules/nw-control-dns-records-public-hosted-zone-infoblox.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion; otherwise lgtm.
Co-authored-by: Kerry Carmichael <[email protected]>
@ankhande: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
/label merge-review-in-progress |
You need to squash the commits before we can merge this PR. /remove-label merge-review-needed |
@@ -53,20 +53,21 @@ spec: | |||
name: infoblox-credentials | |||
gridHost: ${INFOBLOX_GRID_PUBLIC_IP} | |||
wapiPort: 443 | |||
wapiVersion: "2.3.1" | |||
wapiVersion: "2.3.1" <3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, a concrete version is better to be replaced with a placeholder (<version>
) to let the user decide which version suits better their installation.
The This is because your PR targets the If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Update list of all supported wapiVersions in external dns operator documentations
https://issues.redhat.com/browse/OSDOCS-12220
Version(s):
4.16+
Issue:
https://issues.redhat.com/browse/OSDOCS-12220
Link to docs preview:
https://83270--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/external_dns_operator/nw-creating-dns-records-on-infoblox.html
QE review:
Additional information:
Currently in External DNS operator documentation, the wapiVersion present is "2.3.1" which is quite old as there are multiple new versions updated after that.
Also, we raised a test PR[1] with the latest wapiVersion "2.9.1" as the default version for tests, and it passed all the e2e tests. So, "2.9.1" seems to be working fine with our Infoblox instance.
So, we need to update the list of all supported wapiVersions in our product documentation[2] to avoid the confusion :
[1] openshift/external-dns-operator#229
[2] https://docs.openshift.com/container-platform/4.16/networking/external_dns_operator/nw-creating-dns-records-on-infoblox.html