Skip to content

Update list of all supported wapiVersions in External DNS Operator Documentation #83270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ankhande
Copy link

@ankhande ankhande commented Oct 9, 2024

Update list of all supported wapiVersions in external dns operator documentations

https://issues.redhat.com/browse/OSDOCS-12220

Version(s):

4.16+

Issue:

https://issues.redhat.com/browse/OSDOCS-12220

Link to docs preview:

https://83270--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/external_dns_operator/nw-creating-dns-records-on-infoblox.html

QE review:

  • QE has approved this change.

Additional information:

Currently in External DNS operator documentation, the wapiVersion present is "2.3.1" which is quite old as there are multiple new versions updated after that.

  • Here are the list of currently supported wapiVersions: 2.3.1, 2.4, 2.5, 2.6, 2.6.1, 2.7, 2.7.1, 2.7.2, 2.7.3, 2.8, 2.9, 2.9.1.
  • Unless explicitly stated in the release notes, previously available WAPI versions are intended to remain accessible and operative with later versions.

Also, we raised a test PR[1] with the latest wapiVersion "2.9.1" as the default version for tests, and it passed all the e2e tests. So, "2.9.1" seems to be working fine with our Infoblox instance.

So, we need to update the list of all supported wapiVersions in our product documentation[2] to avoid the confusion :
[1] openshift/external-dns-operator#229
[2] https://docs.openshift.com/container-platform/4.16/networking/external_dns_operator/nw-creating-dns-records-on-infoblox.html

@ankhande
Copy link
Author

ankhande commented Oct 9, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2024
Copy link

openshift-ci bot commented Oct 9, 2024

@ankhande: Can not set label peer-review-in-progress: Must be member in one of these teams: [team-red-hat]

In response to this:

/label peer-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2024
Copy link

openshift-ci bot commented Oct 9, 2024

Hi @ankhande. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PoornimaSingour
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 9, 2024
@libander
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 16, 2024

@lihongan
Copy link

@melvinjoseph86 PTAL, thanks

@melvinjoseph86
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 23, 2024
@ankhande
Copy link
Author

/label merge-review-needed

Copy link

openshift-ci bot commented Oct 24, 2024

@ankhande: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lihongan
Copy link

/label merge-review-needed
for @ankhande

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 24, 2024
@kcarmichael08
Copy link
Contributor

Hi, this did not have a peer review by the OpenShift docs team. It needs one before it can be merged. I will do that peer review.

@kcarmichael08 kcarmichael08 removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 24, 2024
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion; otherwise lgtm.

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 24, 2024
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Oct 24, 2024
Copy link

openshift-ci bot commented Oct 25, 2024

@ankhande: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ankhande
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 25, 2024
@agantony
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 25, 2024
@agantony
Copy link
Contributor

You need to squash the commits before we can merge this PR.

/remove-label merge-review-needed
/remove-label merge-review-in-progress

@openshift-ci openshift-ci bot removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Oct 25, 2024
@@ -53,20 +53,21 @@ spec:
name: infoblox-credentials
gridHost: ${INFOBLOX_GRID_PUBLIC_IP}
wapiPort: 443
wapiVersion: "2.3.1"
wapiVersion: "2.3.1" <3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, a concrete version is better to be replaced with a placeholder (<version>) to let the user decide which version suits better their installation.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.19 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.18. And any PR going into main must also target the latest version branch (enterprise-4.19).

If the update in your PR does NOT apply to version 4.19 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants