Fix default metrics_resolution language #4413
Conversation
|
@lpsantil Thank you! These changes look good to me. Can you please squash this into one commit, however? That will help us with seamless cherry-picking and publishing. Thanks again! |
|
@lpsantil Actually, I just noticed that this PR is submitted against enterprise-3.5. Can you please submit it against the master branch, then we can cherry-pick it to the other relevant branches like 3.5? Thanks! Sorry for any confusion! |
|
@ahardin-rh @bfallonf Would you mind reviewing #4411 before I push this stuff to master? |
|
@lpsantil I'm trying to figure out the deal with that PR right now. I think different versions having different capacities might impact what happens there. That said, I think this PR can merge without affecting that one, so feel free to move ahead with this. |
|
Looks like this is still not resolved. I think we should check with @jeremyeder if this guidance is correct for OCP 3.5 and, if so, if this guidance should be updated for other OCP versions as well. If not, we may not need to submit this against master. |
|
@ahardin-rh @lpsantil - I have replied in #4411 . |
ncbaratta
added
the
peer-review-needed
| @@ -185,8 +185,8 @@ These two test cases are presented on the following graph: | |||
| image::https://raw.githubusercontent.com/ekuric/openshift/master/metrics/1_10kpods.png[1000 pods vs 10000 pods monitored during 24 hours] | |||
| endif::openshift-origin[] | |||
|
|
|||
| If the default value of 7 days for `openshift_metrics_duration` and 10 seconds for | |||
| `openshift_metrics_resolution` are preserved, then weekly storage requirements for the Cassandra pod would be: | |||
| If the default value of 7 days for `openshift_metrics_duration` is preserved, and | |||
There was a problem hiding this comment.
s/preserved,/preserved
| If the default value of 7 days for `openshift_metrics_duration` and 10 seconds for | ||
| `openshift_metrics_resolution` are preserved, then weekly storage requirements for the Cassandra pod would be: | ||
| If the default value of 7 days for `openshift_metrics_duration` is preserved, and | ||
| `openshift_metrics_resolution` is set to 10 seconds, then weekly storage requirements for the Cassandra pod would be: |
kalexand-rh
added
peer-review-done
|
@kalexand-rh I'm not sure. I think this is all related to #4411, where @vikram-redhat commented. 🤷♀️ |
|
I am going to close this PR and the associated issue since we never got confirmation from the metrics team. Please feel free to open a new PR/issue if this still needs updating (and perhaps for newer versions of OCP). |
PR for #4412