-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix default metrics_resolution language #4413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,10 +165,10 @@ metrics data in this scenario is: | |
.Data Accumulated by 120 Nodes and 10000 Pods | ||
==== | ||
In a test scenario including 120 nodes and 10000 pods, a 24 hour period | ||
accumulated 25 GB of metrics data. Therefore, the capacity planning formula for | ||
accumulated 11.4 GB of metrics data. Therefore, the capacity planning formula for | ||
metrics data in this scenario is: | ||
|
||
(((11.410 × 10^9^) ÷ 1000) ÷ 24) ÷ 10^6^ = 0.475 MB/hour | ||
(((11.4 × 10^9^) ÷ 1000) ÷ 24) ÷ 10^6^ = 0.475 MB/hour | ||
==== | ||
|
||
|=== | ||
|
@@ -185,8 +185,8 @@ These two test cases are presented on the following graph: | |
image::https://raw.githubusercontent.com/ekuric/openshift/master/metrics/1_10kpods.png[1000 pods vs 10000 pods monitored during 24 hours] | ||
endif::openshift-origin[] | ||
|
||
If the default value of 7 days for `openshift_metrics_duration` and 10 seconds for | ||
`openshift_metrics_resolution` are preserved, then weekly storage requirements for the Cassandra pod would be: | ||
If the default value of 7 days for `openshift_metrics_duration` is preserved, and | ||
`openshift_metrics_resolution` is set to 10 seconds, then weekly storage requirements for the Cassandra pod would be: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/would be/are |
||
|
||
|=== | ||
| |1000 pods | 10000 pods | ||
|
@@ -248,8 +248,8 @@ Cluster Metrics] topic. | |
In the above calculation, approximately 20 percent of the expected size was added as | ||
overhead to ensure that the storage requirements do not exceed calculated value. | ||
|
||
If the `METRICS_DURATION` and `METRICS_RESOLUTION` values are kept at the | ||
default (`7` days and `15` seconds respectively), it is safe to plan Cassandra | ||
If the `METRICS_DURATION` value is kept to the default (`7` days), and `METRICS_RESOLUTION` value | ||
is set to `15` seconds, it is safe to plan Cassandra | ||
storage size requrements for week, as in the values above. | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/preserved,/preserved