-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-12804#Increase vSphere max vols per node #91472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Tue May 13 14:41:11 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few things to consider.
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-overview.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-overview.adoc
Show resolved
Hide resolved
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc
Show resolved
Hide resolved
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc
Outdated
Show resolved
Hide resolved
Nice work! |
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc
Show resolved
Hide resolved
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-overview.adoc
Show resolved
Hide resolved
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-overview.adoc
Outdated
Show resolved
Hide resolved
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc
Outdated
Show resolved
Hide resolved
[id="persistent-storage-csi-vsphere-increase-max-vols-per-node_{context}"] | ||
= Increasing the maximum allowable volumes per node for vSphere | ||
|
||
.Prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As prerequisite customers need to set pvscsiCtrlr256DiskSupportEnabled to true in vCenter.
We need to document it but be VERY careful with the wording.
This is NOT officially supported by VMware and this is a global vCenter setting so even if customers want to try it on say a OCP test cluster, this setting will affect the entire vCenter which could also host production workloads.
@gnufied @RomanBednar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gcharot @gnufied @RomanBednar I searched on this parameter in vSphere docs and didn't find anything, so I don't have a specific place to point users to. Maybe we need to discuss how to approach this due to its sensitive nature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is not documented anywhere in a public facing doc from Broadcom. That is the rub. @gcharot should we document our own stuff or ask customer to talk to Broadcom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention the parameter name but clearly mention that this is not fully supported by VMware as well as pointing out this is a cluster wide option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc
Outdated
Show resolved
Hide resolved
c26ffe2
to
c84cbc8
Compare
modules/persistent-storage-csi-vsphere-increase-max-vols-per-node-procedure.adoc
Outdated
Show resolved
Hide resolved
LGTM - after this comment is addressed. |
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
LGTM |
Version(s): 4.19+
Issue: https://issues.redhat.com/browse/OSDOCS-12804
Link to docs preview: https://91472--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html#persistent-storage-csi-vsphere-increase-max-vols-per-node-overview_persistent-storage-csi-vsphere
QE review:
Additional information:
PTAL: @gcharot @RomanBednar @radeore