Skip to content

OSDOCS-12804#Increase vSphere max vols per node #91472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Apr 1, 2025

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2025
@lpettyjo lpettyjo added this to the Planned for 4.19 GA milestone Apr 1, 2025
@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 1, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 1, 2025

@stevsmit stevsmit added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 1, 2025
Copy link
Member

@stevsmit stevsmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few things to consider.

@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 1, 2025
@stevsmit
Copy link
Member

stevsmit commented Apr 1, 2025

Nice work!

@stevsmit stevsmit removed the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 1, 2025
[id="persistent-storage-csi-vsphere-increase-max-vols-per-node_{context}"]
= Increasing the maximum allowable volumes per node for vSphere

.Prerequisites
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As prerequisite customers need to set pvscsiCtrlr256DiskSupportEnabled to true in vCenter.
We need to document it but be VERY careful with the wording.
This is NOT officially supported by VMware and this is a global vCenter setting so even if customers want to try it on say a OCP test cluster, this setting will affect the entire vCenter which could also host production workloads.
@gnufied @RomanBednar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpettyjo There was a thread opened for this and then flagged as "Done", but I don't see this prerequisite note yet - PTAL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcharot @gnufied @RomanBednar I searched on this parameter in vSphere docs and didn't find anything, so I don't have a specific place to point users to. Maybe we need to discuss how to approach this due to its sensitive nature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is not documented anywhere in a public facing doc from Broadcom. That is the rub. @gcharot should we document our own stuff or ask customer to talk to Broadcom?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention the parameter name but clearly mention that this is not fully supported by VMware as well as pointing out this is a cluster wide option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lpettyjo lpettyjo force-pushed the OSDOCS-12804 branch 2 times, most recently from c26ffe2 to c84cbc8 Compare May 7, 2025 19:41
@RomanBednar
Copy link

LGTM - after this comment is addressed.

Copy link

openshift-ci bot commented May 13, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gcharot
Copy link

gcharot commented May 13, 2025

/lgtm

@radeore
Copy link

radeore commented May 13, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants