Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSDOCS-12804#Increase vSphere max vols per node #91472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OSDOCS-12804#Increase vSphere max vols per node #91472
Changes from all commits
dd5947a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As prerequisite customers need to set pvscsiCtrlr256DiskSupportEnabled to true in vCenter.
We need to document it but be VERY careful with the wording.
This is NOT officially supported by VMware and this is a global vCenter setting so even if customers want to try it on say a OCP test cluster, this setting will affect the entire vCenter which could also host production workloads.
@gnufied @RomanBednar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lpettyjo There was a thread opened for this and then flagged as "Done", but I don't see this prerequisite note yet - PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gcharot @gnufied @RomanBednar I searched on this parameter in vSphere docs and didn't find anything, so I don't have a specific place to point users to. Maybe we need to discuss how to approach this due to its sensitive nature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is not documented anywhere in a public facing doc from Broadcom. That is the rub. @gcharot should we document our own stuff or ask customer to talk to Broadcom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention the parameter name but clearly mention that this is not fully supported by VMware as well as pointing out this is a cluster wide option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.