Skip to content

no-jira: use tech preview rather than custom no upgrade for vsphere multi-network #63818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Apr 14, 2025

fixing test feature set to test multi-network in support of openshift/api#2204

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 14, 2025
@openshift-ci-robot
Copy link
Contributor

@rvanderp3: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rvanderp3: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-vsphere-ovn-multi-network-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.19-e2e-vsphere-ovn-multi-network-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.20-e2e-vsphere-ovn-multi-network-techpreview openshift/installer presubmit Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-techpreview N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rvanderp3
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-techpreview

@openshift-ci-robot
Copy link
Contributor

@rvanderp3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor

mtulio commented Apr 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@tthvo
Copy link
Member

tthvo commented Apr 14, 2025

Let's see if I can approve 😅

/approve

@rna-afk
Copy link
Contributor

rna-afk commented Apr 14, 2025

/approve

1 similar comment
@jhixson74
Copy link
Member

/approve

@jhixson74
Copy link
Member

I guess installer folks can't approve this :-(

@vrutkovs
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74, mtulio, rna-afk, rvanderp3, tthvo, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@rvanderp3
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@rvanderp3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@rvanderp3: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4265f8f into openshift:master Apr 15, 2025
14 checks passed
mehabhalodiya pushed a commit to mehabhalodiya/release that referenced this pull request Apr 15, 2025
jinyunma pushed a commit to jinyunma/release that referenced this pull request Apr 27, 2025
mehabhalodiya pushed a commit to mehabhalodiya/release that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants