Skip to content

OCPBUGS-56067: add verify-deps job back to IBM VPC CSI driver and node label updater #64814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented May 12, 2025

https://issues.redhat.com/browse/OCPBUGS-56067

This reverts #63730 and adds verify-deps back to ibm-vpc-block-csi-driver branches 4.18 - 4.12 and ibm-vpc-node-label-updater branches 4.15 - 4.12.

/hold for openshift/ibm-vpc-block-csi-driver#95 and openshift/ibm-vpc-node-label-updater#52 to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 12, 2025
@openshift-ci-robot
Copy link
Contributor

@dobsonj: This pull request references Jira Issue OCPBUGS-56067, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-56067

This reverts #63730 and adds verify-deps back to ibm-vpc-block-csi-driver branches 4.18 - 4.12 and ibm-vpc-node-label-updater branches 4.15 - 4.12.

/hold for openshift/ibm-vpc-block-csi-driver#95 and openshift/ibm-vpc-node-label-updater#52 to merge first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@openshift-ci openshift-ci bot requested review from gnufied and jsafrane May 12, 2025 22:06
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dobsonj: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.12-verify-deps openshift/ibm-vpc-block-csi-driver presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.13-verify-deps openshift/ibm-vpc-block-csi-driver presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.14-verify-deps openshift/ibm-vpc-block-csi-driver presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.15-verify-deps openshift/ibm-vpc-block-csi-driver presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.16-verify-deps openshift/ibm-vpc-block-csi-driver presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.17-verify-deps openshift/ibm-vpc-block-csi-driver presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.18-verify-deps openshift/ibm-vpc-block-csi-driver presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.12-verify-deps openshift/ibm-vpc-node-label-updater presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.13-verify-deps openshift/ibm-vpc-node-label-updater presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.14-verify-deps openshift/ibm-vpc-node-label-updater presubmit Presubmit changed
pull-ci-openshift-ibm-vpc-node-label-updater-release-4.15-verify-deps openshift/ibm-vpc-node-label-updater presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented May 12, 2025

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member Author

dobsonj commented May 14, 2025

/cc @openshift/storage

Copy link
Contributor

openshift-ci bot commented May 14, 2025

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants