Skip to content

[WIP] CNTRLPLANE-707: Use Calico CNI for management cluster #64839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

[WIP] CNTRLPLANE-707: Use Calico CNI for management cluster #64839

wants to merge 21 commits into from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented May 13, 2025 •
edited
Loading

https://issues.redhat.com/browse/CNTRLPLANE-707

Builds on top of #64789 and adds Calico to the management cluster.
This is currently affected by https://issues.redhat.com/browse/OCPBUGS-56096 so this PR might be merged later (or closed and re-opened) after delivering the fix for OCPBUGS-56096

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@mgencur: This pull request references CNTRLPLANE-707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/CNTRLPLANE-249

Builds on top of #64789 and adds Calico to the management cluster.
This is currently affected by https://issues.redhat.com/browse/OCPBUGS-54574 so this PR might be merged later (or closed and re-opened) after delivering the fix for OCPBUGS-54574

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@mgencur: This pull request references CNTRLPLANE-707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/CNTRLPLANE-249

Builds on top of #64789 and adds Calico to the management cluster.
This is currently affected by https://issues.redhat.com/browse/OCPBUGS-56096 so this PR might be merged later (or closed and re-opened) after delivering the fix for OCPBUGS-54574

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@mgencur: This pull request references CNTRLPLANE-707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/CNTRLPLANE-249

Builds on top of #64789 and adds Calico to the management cluster.
This is currently affected by https://issues.redhat.com/browse/OCPBUGS-56096 so this PR might be merged later (or closed and re-opened) after delivering the fix for OCPBUGS-56096

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bryan-cox and csrwng May 13, 2025 11:30
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign davidvossel, heliubj18 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented May 13, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@mgencur: This pull request references CNTRLPLANE-707 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/CNTRLPLANE-707

Builds on top of #64789 and adds Calico to the management cluster.
This is currently affected by https://issues.redhat.com/browse/OCPBUGS-56096 so this PR might be merged later (or closed and re-opened) after delivering the fix for OCPBUGS-56096

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mgencur
Copy link
Contributor Author

mgencur commented May 13, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 13, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 14, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 15, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 15, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 15, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 15, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 16, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 16, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 19, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

mgencur added 14 commits May 19, 2025 14:08
@mgencur mgencur force-pushed the calico_kubevirt_mgmt branch from b640adf to 60a059f Compare May 19, 2025 18:03
@mgencur
Copy link
Contributor Author

mgencur commented May 19, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 20, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 20, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 20, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur
Copy link
Contributor Author

mgencur commented May 20, 2025

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico

@openshift-ci-robot
Copy link
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mgencur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-main-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.21-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.20-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.19-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.18-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.17-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.16-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed

A total of 191 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@mgencur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico 3bccd15 link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-kubevirt-metal-conformance-calico
ci/prow/step-registry-metadata 3bccd15 link true /test step-registry-metadata

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox Awaiting requested review from bryan-cox

@csrwng csrwng Awaiting requested review from csrwng

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgencur @openshift-ci-robot