Skip to content

WIP: AUTOSCALE-236: Add cluster-resource-override-admission-operator OLM upgrade tests #64990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: AUTOSCALE-236: Add cluster-resource-override-admission-operator OLM upgrade tests #64990

wants to merge 2 commits into from

Conversation

maxcao13
Copy link
Member

Fixes: AUTOSCALE-236
Also bumps the vpa operator images for upgrade tests for convenience.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2025 •
edited by openshift-ci bot
Loading

@maxcao13: This pull request references AUTOSCALE-236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.20.0" version, but multiple target versions were set.

In response to this:

Fixes: AUTOSCALE-236
Also bumps the vpa operator images for upgrade tests for convenience.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@openshift-ci openshift-ci bot requested review from jkyros and joelsmith May 15, 2025 16:17
@maxcao13
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the cro-upgrade-tests branch from f1b909a to c37eddc Compare May 16, 2025 17:33
@maxcao13
Copy link
Member Author

Okay I believe the previous failure is happening bc master is not up to date with 4.20... (release chores not done)

Let's just check that 4.18 -> 4.19 upgrade tests pass using this workflow first.

/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the cro-upgrade-tests branch from c37eddc to c809bcb Compare May 16, 2025 18:28
@maxcao13
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade

Try again? Not really sure why there's suddenly permission errors.

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the cro-upgrade-tests branch from c809bcb to 1d97093 Compare May 16, 2025 19:21
@maxcao13
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the cro-upgrade-tests branch from 1d97093 to b139674 Compare May 16, 2025 22:56
@maxcao13
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the cro-upgrade-tests branch from b139674 to 2caa7ea Compare May 17, 2025 00:47
@maxcao13
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the cro-upgrade-tests branch from 2caa7ea to d4885ea Compare May 20, 2025 16:23
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade openshift/cluster-resource-override-admission-operator presubmit Presubmit changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-e2e-aws-upgrade openshift/cluster-resource-override-admission-operator presubmit Presubmit changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-e2e-aws-upgrade openshift/cluster-resource-override-admission-operator presubmit Presubmit changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade openshift/cluster-resource-override-admission-operator presubmit Presubmit changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.20-e2e-aws-upgrade openshift/cluster-resource-override-admission-operator presubmit Presubmit changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-ci-bundle-cluster-resource-override-admission-operator-bundle openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-e2e-aws-olm openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-e2e-aws-operator openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-images openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-security openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-unit openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-verify openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-ci-bundle-cluster-resource-override-admission-operator-bundle openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-operator openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-images openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-security openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-unit openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-verify openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-main-verify-deps openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-ci-bundle-cluster-resource-override-admission-operator-bundle openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-e2e-aws-olm openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-e2e-aws-operator openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-images openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-security openshift/cluster-resource-override-admission-operator presubmit Ci-operator config changed

A total of 82 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@maxcao13
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.20-e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@maxcao13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-resource-override-admission-operator/release-4.17/e2e-aws-upgrade 2caa7ea link unknown /pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-e2e-aws-upgrade
ci/rehearse/openshift/cluster-resource-override-admission-operator/release-4.18/e2e-aws-upgrade 2caa7ea link unknown /pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-e2e-aws-upgrade
ci/rehearse/openshift/cluster-resource-override-admission-operator/release-4.19/e2e-aws-upgrade d4885ea link unknown /pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade
ci/rehearse/openshift/cluster-resource-override-admission-operator/release-4.20/e2e-aws-upgrade d4885ea link unknown /pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.20-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkyros jkyros Awaiting requested review from jkyros

@joelsmith joelsmith Awaiting requested review from joelsmith

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxcao13 @openshift-ci-robot