Skip to content

OTA-1403: CVO: Run make verify-update on presubmits #65038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OTA-1403: CVO: Run make verify-update on presubmits #65038

wants to merge 2 commits into from

Conversation

DavidHurta
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2025
@openshift-ci openshift-ci bot requested review from petr-muller and wking May 16, 2025 16:12
@DavidHurta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-update

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta
Copy link
Contributor Author

Working as expected:

hack/build-go.sh
Using version from git...
Building binaries into _output/linux/amd64
Building github.com/openshift/cluster-version-operator cluster-version-operator-tests binary (v1.0.0-1426-g07c658d4)
Compressing the cluster-version-operator-tests binary
Building github.com/openshift/cluster-version-operator cluster-version-operator binary (v1.0.0-1426-g07c658d4)
hack/update-test-metadata.sh
Using version from git...
successfully updated metadata
git diff --exit-code HEAD

@DavidHurta DavidHurta force-pushed the cvo-create-verify-job branch from d3cd78a to 4883275 Compare May 16, 2025 16:46
@DavidHurta DavidHurta changed the title WIP: CVO: Run make verify-update on presubmits OTA-1403: CVO: Run make verify-update on presubmits May 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2025 •
edited by openshift-ci bot
Loading

@DavidHurta: This pull request references OTA-1403 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.19" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2025
@DavidHurta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-update

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DavidHurta
Copy link
Contributor Author

I tried to be smart with the run_if_changed, however, it is very easy to accidentally import tests using the testing framework. The tests are introduced by importing a package, for example:

_ "github.com/openshift/cluster-version-operator/test/cvo"

It is possible for us, in the future, to reuse a CVO package in the test/ directory. Introducing in a subsequent PR a Ginkgo test in the CVO package would propagate the test into the cluster-version-operator-tests binary without the presubmit being executed.

The test is not extensive, let me run it on any code changes in the repository.

@DavidHurta DavidHurta force-pushed the cvo-create-verify-job branch from 4883275 to 75f6645 Compare May 20, 2025 13:56
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@DavidHurta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-version-operator-main-verify-update openshift/cluster-version-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@DavidHurta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-verify-update

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@DavidHurta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DavidHurta
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2025
@DavidHurta DavidHurta requested a review from petr-muller May 20, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking Awaiting requested review from wking

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidHurta @openshift-ci-robot @petr-muller