Skip to content

SPLAT-2039: Tweeks to vSphere hybrid env steps #65160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SPLAT-2039: Tweeks to vSphere hybrid env steps #65160

wants to merge 2 commits into from
+11 −4

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented May 20, 2025 •
edited
Loading

SPLAT-2039

Changes

  • Deprovision:
    • fixed path for cluster kubeconfig
    • added logic to delete job namespace in virt cluster
    • changed order of step to before cluster is destroyed
  • Provision:
    • modified vm creation to create data volume with disk size of 60Gi to prevent low disk space warnings during e2e

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2039 which is a valid jira issue.

In response to this:

SPLAT-2039

Changes

  • updated vsphere virt deprovision to delete job namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from smg247 and xueqzhan May 20, 2025 17:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2025
@vr4manta
Copy link
Contributor Author

/hold
waiting to verify deprovision works as expected

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2025
@vr4manta vr4manta force-pushed the SPLAT-2039_cleanup branch 2 times, most recently from 9d589b6 to 3aba130 Compare May 21, 2025 10:58
@vr4manta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@vr4manta vr4manta force-pushed the SPLAT-2039_cleanup branch from 3aba130 to 58d8099 Compare May 22, 2025 11:39
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2039 which is a valid jira issue.

In response to this:

SPLAT-2039

Changes

  • updated vsphere virt deprovision to delete job namespace
  • changed order of step to before cluster is destroyed.
  • modified vm creation to create data volume with disk size of 60Gi to prevent low disk space warnings during e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2039 which is a valid jira issue.

In response to this:

SPLAT-2039

Changes

  • Deprovision:
  • fixed path for cluster kubeconfig
  • added logic to delete job namespace in virt cluster
  • changed order of step to before cluster is destroyed
  • Provision:
  • modified vm creation to create data volume with disk size of 60Gi to prevent low disk space warnings during e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta changed the title SPLAT-2039: Clean up vSphere hybrid namespace from Openshift Virt cluster. SPLAT-2039: Tweeks to vSphere hybrid env steps May 22, 2025
@vr4manta vr4manta force-pushed the SPLAT-2039_cleanup branch from f98ed83 to 03abdd9 Compare May 22, 2025 19:39
@vr4manta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.21-e2e-vsphere-ovn-hybrid-env openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-vsphere-ovn-hybrid-env openshift/installer presubmit Registry content changed
periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-hybrid-env N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2025

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/main/e2e-vsphere-ovn-hybrid-env 03abdd9 link unknown /pj-rehearse pull-ci-openshift-installer-main-e2e-vsphere-ovn-hybrid-env

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smg247 smg247 Awaiting requested review from smg247

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

@jcpowermac jcpowermac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vr4manta @openshift-ci-robot @jcpowermac