-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Move cli-ocm into oc #65198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Move cli-ocm into oc #65198
Conversation
c48acd8
to
ee925d8
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-openshift-oc-master-supplemental-images-images |
@danilo-gemoli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@danilo-gemoli: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have been building
cli-ocm
via aBuildConfig
and push it intoregistry.ci.openshift.org
.Folks use this image into their
ci-operator
configurations like so:and the image gets resolved from
quay.io/openshift/ci:ci_cli-ocm_latest
.This means that we have to trigger a
BuildConfig
and then manually push the outcome intoquay.io
manually, every time someone needs a new version of this image.By moving it into the
ci-operator
'sopenshift/oc
configuration, the whole mechanism of building and pushing will be handled entirely byci-operator
.As a final yet important note: this PR isn't enough by itself.ci-operator
is going to promote the image to:whereas thebase_images
(see the snipped right above) pulls it from:If we want to go down this route we have to follow this up with another PR and update a bunch ofci-operator
configurations, such as thebase_images
would look like so: