Skip to content

Enable qe label requirement in ccm gcp repo z-stream branches #65207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shellyyang1989
Copy link
Contributor

To ensure pre-merge testing before PR merge for z-stream bugs, I wanted to experiment on enabling qe-approved label requirement to gate PR merging in ccm gcp repo. Introducing no-qe as well to allow overriding the qe-approved label for some exceptions.

@shellyyang1989
Copy link
Contributor Author

/hold

need to communicate with DPTP to see if it makes sense

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2025
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shellyyang1989
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from elmiko and theobarberbany May 21, 2025 15:17
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 21, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@shellyyang1989: no rehearsable tests are affected by this change

Copy link
Contributor

openshift-ci bot commented May 21, 2025

@shellyyang1989: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants