OTA-1542 skip rhel worker update for ocp 4.19+ #65369
Conversation
|
@jiajliu: GitHub didn't allow me to request PR reviews from the following users: nobody. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
approved
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-automated-release-stable-4.19-upgrade-from-stable-4.19-aws-ipi-f999 |
|
@jiajliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
bot
removed
the
approved
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-automated-release-stable-4.19-upgrade-from-stable-4.19-aws-ipi-f999 |
|
@jiajliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 1728 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gpei, jiajliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@jiajliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
| @@ -389,7 +389,7 @@ echo -e "The source release version is gotten from clusterversion resource, that | |||
| export UPGRADE_FAILURE_TYPE="overall" | |||
| # The cases are from existing general checkpoints enabled implicitly in upgrade step, which may be a possible UPGRADE_FAILURE_TYPE | |||
| export IMPLICIT_ENABLED_CASES="" | |||
| if [[ $(oc get nodes -l node.openshift.io/os_id=rhel) != "" ]]; then | |||
There was a problem hiding this comment.
Good catch.
Shall we update cucushift-chainupgrade-toimage together ?
|
@jiajliu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
From 4.19, all rhcos nodes are including
node.openshift.io/os_id=rhellabel, which will cause the upgrade job without rhel workers run tests incucushift-upgrade-rhel-workerstep unexpectedly and the upgrade failing finally(failed job).Considering the above change and rhel worker is not supported from 4.19, this pr is limiting the test in
cucushift-upgrade-rhel-workerstep only applicable for ocp 4.18 and below versions.Test pass.
cc @jianlinliu @gpei to review, thanks.