Skip to content

hypershift: fix 4.21 presub HO ref #74149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 30, 2026
Merged

hypershift: fix 4.21 presub HO ref #74149

openshift-merge-bot merged 1 commit into from
Jan 30, 2026
+8 −11

Conversation

@sjenning
Copy link
Contributor

@sjenning sjenning commented Jan 29, 2026 •
edited
Loading

Presub failures in openshift/hypershift#7604 uncovered that, during branch cut, we didn't switch the hypershift-operator to ref the image built from main, but continues to use a hypershift-operator image built from the PR branch.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre January 29, 2026 20:08
@sjenning sjenning changed the title hypershift: fix 4.12 presub HO ref hypershift: fix 4.21 presub HO ref Jan 29, 2026
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2026
@sjenning
Copy link
Contributor Author

sjenning commented Jan 29, 2026

/pj-rehearse pull-ci-openshift-hypershift-release-4.21-e2e-aws

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 29, 2026

@sjenning: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

bryan-cox commented Jan 29, 2026

/lgtm

@bryan-cox
Copy link
Member

bryan-cox commented Jan 29, 2026

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 29, 2026
@bryan-cox
Copy link
Member

bryan-cox commented Jan 29, 2026

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026
@csrwng
Copy link
Contributor

csrwng commented Jan 29, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 29, 2026

[REHEARSALNOTIFIER]
@sjenning: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-release-4.21-e2e-aks openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aks-4-20 openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aks-override openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws-4-20 openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws-autonode openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws-metrics openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws-minimal openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws-override openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws-techpreview openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-aws-upgrade-hypershift-operator openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-kubevirt-aws-ovn-reduced openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-kubevirt-azure-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-kubevirt-metal-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-openstack-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-openstack-aws-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-openstack-aws-csi-cinder openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-openstack-aws-csi-manila openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-e2e-openstack-aws-nfv openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-images openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-okd-scos-e2e-aws-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-release-4.21-okd-scos-images openshift/hypershift presubmit Ci-operator config changed

A total of 77 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bryan-cox
Copy link
Member

bryan-cox commented Jan 29, 2026

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sjenning
Copy link
Contributor Author

sjenning commented Jan 29, 2026

/pj-rehearse pull-ci-openshift-hypershift-release-4.21-e2e-aws

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 29, 2026

@sjenning: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

bryan-cox commented Jan 30, 2026

/pj-rehearse ack

pull-ci-openshift-hypershift-release-4.21-e2e-aws passed

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2026

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 30, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 19b906f into openshift:master Jan 30, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@csrwng csrwng

@bryan-cox bryan-cox

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjenning @openshift-ci-robot @bryan-cox @csrwng