OCPBUGS-52306: [release-4.17] metrics: Fix Metrics should have the correct labels test

[zeeke]

release-4.17 backport of

• metrics: Fix Metrics should have the correct labels test k8snetworkplumbingwg/sriov-network-operator#785

sriov_kubepoddevice metric might end up in the Prometheus database after a while, as the default scrape interval is 30s. This leads to failures in the end-to-end lane like:

[sriov] Metrics Exporter When Prometheus operator is available [It] Metrics should have the correct labels
/root/opr-ocp2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_exporter_metrics.go:132

  [FAILED] no value for metric sriov_kubepoddevice

Put the metric assertion in an Eventually statement

[zeeke]

/jira backport OCPBUGS-52304

[openshift-ci-robot]

@zeeke: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick OCPBUGS-52304

In response to this:

/jira backport OCPBUGS-52304

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of OCPBUGS-52304 in a new PR and assign it to you.

In response to this:

@zeeke: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick OCPBUGS-52304

In response to this:

/jira backport OCPBUGS-52304

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zeeke]

/jira cherrypick OCPBUGS-52304

[openshift-ci-robot]

@zeeke: Jira Issue OCPBUGS-52304 has been cloned as Jira Issue OCPBUGS-52306. Will retitle bug to link to clone.
/retitle OCPBUGS-52306: metrics: Fix Metrics should have the correct labels test

In response to this:

/jira cherrypick OCPBUGS-52304

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@zeeke: This pull request references Jira Issue OCPBUGS-52306, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-52304 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
• expected dependent Jira Issue OCPBUGS-52304 to target a version in 4.18.0, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

release-4.17 backport of

• metrics: Fix Metrics should have the correct labels test k8snetworkplumbingwg/sriov-network-operator#785

sriov_kubepoddevice metric might end up in the Prometheus database after a while, as the default scrape interval is 30s. This leads to failures in the end-to-end lane like:

[sriov] Metrics Exporter When Prometheus operator is available [It] Metrics should have the correct labels
/root/opr-ocp2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_exporter_metrics.go:132

 [FAILED] no value for metric sriov_kubepoddevice

Put the metric assertion in an Eventually statement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zeeke]

/jira refresh

cc @SchSeba

[openshift-ci-robot]

@zeeke: This pull request references Jira Issue OCPBUGS-52306, which is invalid:

• expected dependent Jira Issue OCPBUGS-52304 to target a version in 4.18.0, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

cc @SchSeba

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zeeke]

/test e2e-telco5g-sriov

[openshift-ci]

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zeeke]

/jira refresh

[openshift-ci-robot]

@zeeke: This pull request references Jira Issue OCPBUGS-52306, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-52304 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-52304 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
• bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cgoncalves]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [zeeke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zeeke]

@SchSeba @ajaggapa can you please take a look at this test backport fix?
labels backport-risk-assessed and cherry-pick-approved are needed

[ajaggapa]

/label cherry-pick-approved

[zeeke]

/label backport-risk-assessed

[openshift-ci-robot]

@zeeke: Jira Issue OCPBUGS-52306: All pull requests linked via external trackers have merged:

• openshift/sriov-network-operator#1060

Jira Issue OCPBUGS-52306 has been moved to the MODIFIED state.

In response to this:

release-4.17 backport of

• metrics: Fix Metrics should have the correct labels test k8snetworkplumbingwg/sriov-network-operator#785

sriov_kubepoddevice metric might end up in the Prometheus database after a while, as the default scrape interval is 30s. This leads to failures in the end-to-end lane like:

[sriov] Metrics Exporter When Prometheus operator is available [It] Metrics should have the correct labels
/root/opr-ocp2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_exporter_metrics.go:132

 [FAILED] no value for metric sriov_kubepoddevice

Put the metric assertion in an Eventually statement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: cannot checkout OCPBUGS-52304: error checking out "OCPBUGS-52304": exit status 1 error: pathspec 'OCPBUGS-52304' did not match any file(s) known to git

In response to this:

@zeeke: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick OCPBUGS-52304

In response to this:

/jira backport OCPBUGS-52304

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zeeke]

/jira backport release-4.16

[openshift-ci-robot]

@zeeke: The following backport issues have been created:

• OCPBUGS-53440 for branch release-4.16

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.16

In response to this:

/jira backport release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: new pull request created: #1068

In response to this:

@zeeke: The following backport issues have been created:

• OCPBUGS-53440 for branch release-4.16

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.16

In response to this:

/jira backport release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon
This PR has been included in build sriov-network-config-daemon-container-v4.17.0-202503210904.p0.gc1b8c02.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator
This PR has been included in build sriov-network-operator-container-v4.17.0-202503210904.p0.gc1b8c02.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook
This PR has been included in build sriov-network-webhook-container-v4.17.0-202503210904.p0.gc1b8c02.assembly.stream.el9.
All builds following this will include this PR.