[release-4.16] OCPBUGS-53440: metrics: Fix Metrics should have the correct labels test
#1068
Conversation
`sriov_kubepoddevice` metric might end up in the Prometheus database after a while, as the default scrape interval is 30s. This leads to failures in the end-to-end lane like: ``` [sriov] Metrics Exporter When Prometheus operator is available [It] Metrics should have the correct labels /root/opr-ocp2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_exporter_metrics.go:132 [FAILED] no value for metric sriov_kubepoddevice ``` Put the metric assertion in an `Eventually` statement Signed-off-by: Andrea Panattoni <[email protected]>
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-52306 with correct target version. Will retitle the PR to link to the clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
Metrics should have the correct labels testMetrics should have the correct labels test
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53440, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/test e2e-telco5g-sriov |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
ajaggapa,
anuragthehatter,
asood-rh,
evgenLevin,
huiran0826,
jechen0648,
kononovn,
mffiedler and
qiowang721
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/jira refresh @SchSeba please take a look at this backport |
openshift-ci-robot
added
jira/valid-bug
|
@zeeke: This pull request references Jira Issue OCPBUGS-53440, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, SchSeba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 990b624
into
openshift:release-4.16
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-53440: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-53440 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-operator |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-config-daemon |
|
[ART PR BUILD NOTIFIER] Distgit: sriov-network-webhook |
14 participants
This is an automated cherry-pick of #1060
/assign openshift-ci-robot