Skip to content

Improvements for XsensDataReader #4063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexbeattie42
Copy link
Contributor

@alexbeattie42 alexbeattie42 commented Apr 14, 2025

Fixes issue #3956

Brief summary of changes

  1. Add a configuration option to XSensDataReaderSettings to specify a known data rate (sampling frequency).

  2. Add a configuration option to XSensDataReaderSettings to specify a custom delimiter.

  3. Add the ability to read in either a Rotation Matrix, Quaternion, or Euler angle values from Xsens files.

  4. Update the parser to handle the path separator for data_folder.

  5. Fix a memory leak in the original implementation.

  6. Verify integrity and uniformity of all files.

Testing I've completed

  • Existing unit tests
  • Tested locally

Looking for feedback on...

CHANGELOG.md (choose one)

  • Will update after review

This change is Reviewable

@alexbeattie42 alexbeattie42 changed the title XsensDataReader Improvements Improvements for XsensDataReader Apr 15, 2025
@alexbeattie42
Copy link
Contributor Author

@nickbianco could you take a look?

@nickbianco
Copy link
Member

@aymanhab would you be willing to review this? I think you originally authored XsensDataReader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants