chore(package.json): update clean build command to include missing directories, add global cursor-rules #3323
Conversation
…ctories, add global cursor-rules
WalkthroughTwo new markdown configuration files, Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
.cursor/rules/global.mdc (2)
1-5: Definedescriptionandglobsfor clarity
The frontmatter fieldsdescriptionandglobsare currently empty. To ensure this rule is properly documented and applied, please provide a concise description and specify the file patterns it should match. For example:description: "Professional guidelines for senior front-end developers" globs: - "packages/**/*.vue"
7-7: Review content language consistency
The rule content is written in Chinese. If the project is intended for a multilingual audience, consider adding an English translation or noting that rules are maintained in Chinese. This will help contributors understand and apply the rule correctly..cursor/rules/product.mdc (2)
2-4: Specifyglobsand enhance description
Similar to the global rules file, theglobsfield is empty. Please document which files this rule should apply to and consider elaborating on the description. For example:description: "Guidelines for writing product requirements and development documentation" globs: - "docs/**/*.md"
9-10: Fix a minor typo in the guideline text
There's a small typo in the first bullet point: "易懂一写" should be "易懂".- - 需求尽量写的简单清晰易懂一写 + - 需求尽量写的简单清晰易懂
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.cursor/rules/global.mdc(1 hunks).cursor/rules/product.mdc(1 hunks)package.json(1 hunks)
| "lint": "eslint \"packages/**/{*.vue,*.js,*.ts}\" --quiet --fix", | ||
| "lint:doc": "eslint \"examples/**/{*.vue,*.js,*.ts}\" --quiet --fix", | ||
| "clean:build": "rimraf packages/dist2 packages/dist3 packages/dist2.7 packages/renderless/dist packages/theme/dist packages/theme-saas/dist", | ||
| "clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify and optionally refactor the clean:build script
Confirm that the newly added directories (packages/utils/dist and packages/vue-hooks/dist) actually exist in the repo and that no other build artifacts are missing from cleanup. Test the script locally to ensure it fails fast on missing paths. For improved maintainability, consider splitting the long rimraf command:
- "clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
+ "clean:build": "rimraf \\
+ packages/dist2 \\
+ packages/dist3 \\
+ packages/utils/dist \\
+ packages/vue-hooks/dist \\
+ packages/renderless/dist \\
+ packages/theme/dist \\
+ packages/theme-saas/dist",🏁 Script executed:
#!/usr/bin/env bash
# Verification script for clean:build paths
for dir in packages/utils/dist packages/vue-hooks/dist; do
if [ ! -d "$dir" ]; then
echo "Error: Directory not found: $dir"
exit 1
fi
done
echo "Success: All specified directories exist"Length of output: 207
🏁 Script executed:
#!/usr/bin/env bash
# List all dist directories under packages/
echo "=== All dist directories under packages ==="
find packages -type d | grep '/dist' || true
# Locate actual utils and vue-hooks packages (and their dist subdirs if any)
echo -e "\n=== Packages matching utils or vue-hooks ==="
find packages -maxdepth 3 -type d | grep -E 'packages/(utils|vue-hooks)' || trueLength of output: 1511
Fix invalid cleanup paths in clean:build
The directories packages/utils/dist and packages/vue-hooks/dist do not exist in this repo. Please remove or correct these entries—either update your packages to emit a dist folder or drop them from the cleanup script.
• File: package.json, script clean:build
• Lines: ~100
Suggested diff:
--- a/package.json
+++ b/package.json
@@ -100,7 +100,6 @@
- "clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
+ "clean:build": "rimraf packages/dist2 packages/dist3 packages/renderless/dist packages/theme/dist packages/theme-saas/dist",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist", | |
| "clean:build": "rimraf packages/dist2 packages/dist3 packages/renderless/dist packages/theme/dist packages/theme-saas/dist", |
zzcr
changed the title
更新清理构建命令以包含缺失的目录,添加全局的cursor-rules
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit