Skip to content

chore(package.json): update clean build command to include missing directories, add global cursor-rules #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzcr merged 1 commit into from
Apr 21, 2025
Merged

chore(package.json): update clean build command to include missing directories, add global cursor-rules #3323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .cursor/rules/global.mdc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
description:
globs:
alwaysApply: true
---

作为一个很专业的高级前端开发工程师，从专业的角度出发解决需求和问题。
10 changes: 10 additions & 0 deletions .cursor/rules/product.mdc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
description: 用于写产品需求和开发文档
globs:
alwaysApply: false
---

# 文档需求编写

- 需求尽量写的简单清晰易懂一写
- 在需求设计阶段遵从逐步迭代的原则，早期版本可以尽量简洁一些
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"format": "prettier --write --cache packages/**/{*.vue,*.js,*.ts,*.jsx,*.tsx,*.less} examples/**/{*.vue,*.js,*.ts,*.jsx,*.tsx} internals/**/{*.js,*.ts}",
"lint": "eslint \"packages/**/{*.vue,*.js,*.ts}\" --quiet --fix",
"lint:doc": "eslint \"examples/**/{*.vue,*.js,*.ts}\" --quiet --fix",
"clean:build": "rimraf packages/dist2 packages/dist3 packages/dist2.7 packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
"clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
Copy link

@coderabbitai coderabbitai bot Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify and optionally refactor the clean:build script
Confirm that the newly added directories (packages/utils/dist and packages/vue-hooks/dist) actually exist in the repo and that no other build artifacts are missing from cleanup. Test the script locally to ensure it fails fast on missing paths. For improved maintainability, consider splitting the long rimraf command:

- "clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
+ "clean:build": "rimraf \\
+   packages/dist2 \\
+   packages/dist3 \\
+   packages/utils/dist \\
+   packages/vue-hooks/dist \\
+   packages/renderless/dist \\
+   packages/theme/dist \\
+   packages/theme-saas/dist",

🏁 Script executed:

#!/usr/bin/env bash
# Verification script for clean:build paths
for dir in packages/utils/dist packages/vue-hooks/dist; do
  if [ ! -d "$dir" ]; then
    echo "Error: Directory not found: $dir"
    exit 1
  fi
done
echo "Success: All specified directories exist"

Length of output: 207

🏁 Script executed:

#!/usr/bin/env bash
# List all dist directories under packages/
echo "=== All dist directories under packages ==="
find packages -type d | grep '/dist' || true

# Locate actual utils and vue-hooks packages (and their dist subdirs if any)
echo -e "\n=== Packages matching utils or vue-hooks ==="
find packages -maxdepth 3 -type d | grep -E 'packages/(utils|vue-hooks)' || true

Length of output: 1511

Fix invalid cleanup paths in clean:build
The directories packages/utils/dist and packages/vue-hooks/dist do not exist in this repo. Please remove or correct these entries—either update your packages to emit a dist folder or drop them from the cleanup script.

• File: package.json, script clean:build
• Lines: ~100

Suggested diff:

--- a/package.json
+++ b/package.json
@@ -100,7 +100,6 @@
-    "clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
+    "clean:build": "rimraf packages/dist2 packages/dist3 packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"clean:build": "rimraf packages/dist2 packages/dist3 packages/utils/dist packages/vue-hooks/dist packages/renderless/dist packages/theme/dist packages/theme-saas/dist",
"clean:build": "rimraf packages/dist2 packages/dist3 packages/renderless/dist packages/theme/dist packages/theme-saas/dist",

"clean:dependencies": "rm -rf node_modules /**/node_modules",
"prettier": "prettier --config .prettierrc --write ."
},
Expand Down
Loading