Skip to content

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Aug 18, 2022

Summary

Hi, her is a skeleton implementation for Amazon AWS S3 support - It need more work, especially on the S3 integration part , but it is a good start - in particular if you do not know OTP that well. It may serve as a template for implementing support for other storage providers as well.

I am not going to complete this PR - feel free to cherry-pick my initial commit and complete the work.

Unit tests

Test needs to be added.

Documentation

Documentation needs to be added.

Changelog

This should be in the changelog - if ever merged.

@t2gran t2gran added the !New Feature A functional feature targeting the end user. label Aug 18, 2022
@t2gran t2gran added this to the 2.2 milestone Aug 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4391 (13f6df4) into dev-2.x (37bd51e) will decrease coverage by 0.14%.
The diff coverage is 2.87%.

@@              Coverage Diff              @@
##             dev-2.x    #4391      +/-   ##
=============================================
- Coverage      58.05%   57.91%   -0.15%     
- Complexity     11028    11030       +2     
=============================================
  Files           1454     1462       +8     
  Lines          58677    58827     +150     
  Branches        6750     6759       +9     
=============================================
+ Hits           34063    34067       +4     
- Misses         22585    22729     +144     
- Partials        2029     2031       +2     
Impacted Files Coverage Δ
...anner/ext/datastore/aws/AbstractAwsDataSource.java 0.00% <0.00%> (ø)
...planner/ext/datastore/aws/AwsDataSourceModule.java 0.00% <0.00%> (ø)
...ner/ext/datastore/aws/AwsDataSourceRepository.java 0.00% <0.00%> (ø)
...nner/ext/datastore/aws/AwsDirectoryDataSource.java 0.00% <0.00%> (ø)
...ipplanner/ext/datastore/aws/AwsFileDataSource.java 0.00% <0.00%> (ø)
...lanner/ext/datastore/aws/AwsOutFileDataSource.java 0.00% <0.00%> (ø)
...tripplanner/ext/datastore/aws/AwsOutputStream.java 0.00% <0.00%> (ø)
...rg/opentripplanner/ext/datastore/aws/S3Object.java 0.00% <0.00%> (ø)
...ipplanner/datastore/configure/DataStoreModule.java 68.75% <0.00%> (-9.83%) ⬇️
...entripplanner/standalone/config/StorageConfig.java 91.42% <50.00%> (-5.35%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@t2gran t2gran modified the milestones: 2.2, 2.3 Nov 1, 2022
@t2gran t2gran modified the milestones: 2.3, 2.4 Apr 24, 2023
@t2gran t2gran modified the milestones: 2.4, 2.5 (next release) Sep 13, 2023
@t2gran t2gran modified the milestones: 2.5, 2.6 (next release) Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants