Use time-independent heuristic search #4616
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesj
commented
Nov 18, 2022
| RaptorTripScheduleSearch<T> tripSearch(SearchDirection direction); | ||
|
|
||
| default T getHeuristicTrip() { | ||
| return getTripSchedule(0); |
There was a problem hiding this comment.
TOOD: This needs its own implementation which contains the minimum run and dwell times for the pattern.
slvlirnoff
reviewed
Nov 23, 2022
| } | ||
|
|
||
| private void updateNewBestTimeCostAndRound(int stop, int time, int cost, boolean isTransit) { | ||
| if (heuristicRounds[stop] + roundProvider.round() > roundMaxLimit) { |
There was a problem hiding this comment.
this check could be potentially done before alighting/transfering to avoid computing time and cost
hannesj
force-pushed
the
otp2_new_heuristic
branch
from
6f40fe7 to
c2601c0
Compare
hannesj
force-pushed
the
otp2_new_heuristic
branch
from
c2601c0 to
f061554
Compare
hannesj
force-pushed
the
otp2_new_heuristic
branch
from
f061554 to
1b8a737
Compare
hannesj
force-pushed
the
otp2_new_heuristic
branch
from
1b8a737 to
bc5f2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create a new heuristic search, which is independent of time, and only cares about minimum duration, rounds, and cost.
Issue
Part of #3748
Unit tests
TODO!