-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Netex: check and use gml:pos tag if Latitude and Longitude doesn't exists #5697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netex: check and use gml:pos tag if Latitude and Longitude doesn't exists #5697
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5697 +/- ##
==========================================
Coverage 67.69% 67.69%
- Complexity 16369 16374 +5
==========================================
Files 1890 1890
Lines 71812 71817 +5
Branches 7407 7409 +2
==========================================
+ Hits 48611 48617 +6
Misses 20693 20693
+ Partials 2508 2507 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| static WgsCoordinate mapToDomain(SimplePoint_VersionStructure point) { | ||
| if (point == null || point.getLocation() == null) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc for the mapToDomain method is obsolete, this PR gives a good opportunity to update it.
- You can explain here that we need to convert from the LON/LAT convention in GML to the LAT/LON convention in WGS since this is a usual source of bug/confusion.
- You can also describe here the fallback logic you implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giuseppesaraceno can you update the doc?
|
I looked at this as well, looks good - but I will let someone from another organization take the second review. (@vpaturet and I are both from Entur). |
|
I have converted this to a draft. Please convert it back to a Pull Request when you have updated the Javadoc. |
Summary
The coordinate mapper assume that is used Latitude and Longitude tag, but these tags can use replaced by gml:pos tag (used in some Netex italian files).
Unit tests
Created a unit test handleCoordinateWithGmlPosition in WgsCoordinateMapperTest.
Tested with italian Netex files.