Skip to content

Conversation

@jtorin
Copy link
Contributor

@jtorin jtorin commented May 28, 2024

Summary

With this change it's possible to differentiate between entries added because of configuration and those from runtime requests, the latter being candidates for the former.

From config:

Initializing cache with request: StreetRelevantOptions{transferMode: WALK, walk: WalkPreferences{speed: 0.69, boardCost: $0}, street: StreetPreferences{accessEgress: AccessEgressPreferences{maxDuration: DurationForStreetMode{default:50m, WALK:48m10s}}, maxDirectDuration: DurationForStreetMode{default:1h1m40s, CAR:1d}}}

From runtime:

Adding runtime request to cache: StreetRelevantOptions{transferMode: WALK, street: StreetPreferences{accessEgress: AccessEgressPreferences{maxDuration: DurationForStreetMode{default:50m}}, maxDirectDuration: DurationForStreetMode{default:1h1m40s, CAR:1d}}}

Issue

This makes it much easier to find and handle new transfer cache additions in the logs.

Testing

Manually tested for both cases.

With this it's possible to differentiate between entries added because of
configuration and those from runtime requests, the latter being candidates
for the former.
@jtorin jtorin requested a review from a team as a code owner May 28, 2024 07:54
@codecov
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (39a7270) to head (e9b1e93).
Report is 2 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5874   +/-   ##
==========================================
  Coverage      68.37%   68.38%           
- Complexity     16680    16683    +3     
==========================================
  Files           1914     1914           
  Lines          72658    72664    +6     
  Branches        7453     7453           
==========================================
+ Hits           49683    49691    +8     
+ Misses         20418    20416    -2     
  Partials        2557     2557           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ter/transit/request/RaptorRequestTransferCache.java

Co-authored-by: Henrik Abrahamsson <[email protected]>
@leonardehrenfried leonardehrenfried self-requested a review May 28, 2024 09:36
@jtorin jtorin merged commit 1b474d2 into opentripplanner:dev-2.x May 28, 2024
t2gran pushed a commit that referenced this pull request May 28, 2024
@t2gran t2gran added this to the 2.6 (next release) milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants