Fix debug client after breaking change in dependency graphql-request #5899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5899 +/- ##
=============================================
+ Coverage 68.61% 68.63% +0.02%
- Complexity 16823 16837 +14
=============================================
Files 1927 1927
Lines 72942 72955 +13
Branches 7476 7482 +6
=============================================
+ Hits 50050 50075 +25
+ Misses 20318 20299 -19
- Partials 2574 2581 +7 ☔ View full report in Codecov by Sentry. |
…nt with hostname if it does not have one
testower
force-pushed
the
fix-graphql-request-breaking-change-in-url
branch
from
8339d62 to
0177051
Compare
| try { | ||
| // the URL constructor will throw exception if endpoint is not a valid URL, | ||
| // e.g. if it is a relative path | ||
| new URL(endpoint); |
There was a problem hiding this comment.
Does this line do anything?
There was a problem hiding this comment.
Yes, it throws an exception if endpoint is not a valid URL
There was a problem hiding this comment.
🤦 oh ok, reading the comments helps
leonardehrenfried
approved these changes
Jun 11, 2024
|
As agreed with the dev team, this only needs a single reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug client is broken if VITE_API_URL is a relative path (which it is by default). This is due to a breaking change in v7.0.0 of graphql-request, which I overlooked when approving the upgrade: https://github.com/jasonkuhrt/graphql-request/releases/tag/7.0.0
This PR checks validity of VITE_API_URL by passing it to the URL constructor. If exception is thrown, we prefix it with the window's origin (which used to be the default behavior).
I still need to test this PRTested locally.