Fix incorrect mapping of flex safe duration offset #6059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6059 +/- ##
==========================================
Coverage 69.78% 69.78%
Complexity 17359 17359
==========================================
Files 1962 1962
Lines 74359 74359
Branches 7624 7624
==========================================
+ Hits 51893 51895 +2
+ Misses 19823 19821 -2
Partials 2643 2643 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
habrahamsson-skanetrafiken
requested review from
binh-dam-ibigroup and
optionsome
optionsome
approved these changes
Sep 13, 2024
binh-dam-ibigroup
approved these changes
Sep 16, 2024
t2gran
pushed a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During #5796 I made a mistake by interpreting the safe_duration_offset as a number of seconds. The spec clearly states though that it's a number of minutes.
Issue
MobilityData/gtfs-flex#79
Unit tests
Updated.