Skip to content

Conversation

@leonardehrenfried
Copy link
Member

Summary

After #6045 was merged I realised that we should have a proper mapper for the realtime state since this forces you to correctly deal with all enum types.

Case in point, the current code would break with the real time state DELETED. I've mapped it to CANCELLED.

Issue

None.

Unit tests

None.

@leonardehrenfried leonardehrenfried added !Technical Debt Improve code quality, no functional changes. +Skip Changelog This is not a relevant change for a product owner since last release. labels Sep 27, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner September 27, 2024 07:55
@leonardehrenfried leonardehrenfried changed the title Add proper mapper for GTFS GraphQL realtime state Add mapper for GTFS GraphQL real time state Sep 27, 2024
@codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.84%. Comparing base (2cfbd7b) to head (d49e5fa).
Report is 26 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...planner/apis/gtfs/mapping/RealtimeStateMapper.java 37.50% 4 Missing and 1 partial ⚠️
...ipplanner/apis/gtfs/datafetchers/StoptimeImpl.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6099   +/-   ##
==========================================
  Coverage      69.83%   69.84%           
- Complexity     17461    17466    +5     
==========================================
  Files           1975     1976    +1     
  Lines          74624    74632    +8     
  Branches        7638     7638           
==========================================
+ Hits           52115    52126   +11     
+ Misses         19858    19855    -3     
  Partials        2651     2651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried merged commit 5fee2ff into opentripplanner:dev-2.x Oct 1, 2024
5 checks passed
@leonardehrenfried leonardehrenfried deleted the gfts-leg-node-refetch branch October 1, 2024 08:07
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Skip Changelog This is not a relevant change for a product owner since last release. !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants