Fix hop geometries when one pattern is replaced by another with different number of stops #6136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach has some issues and needs to be discussed in the developer meeting. |
|
As discussed in the developer meeting I am going to work on the shape generation at the point of generating new pattern. |
miklcct
force-pushed
the
fix-nextLeg-outOfBounds
branch
from
56131a8 to
2dfaddf
Compare
miklcct
force-pushed
the
fix-nextLeg-outOfBounds
branch
from
2dfaddf to
8753f82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6136 +/- ##
==========================================
Coverage 69.91% 69.91%
- Complexity 17736 17740 +4
==========================================
Files 2006 2006
Lines 75526 75521 -5
Branches 7730 7731 +1
==========================================
- Hits 52804 52801 -3
+ Misses 20036 20035 -1
+ Partials 2686 2685 -1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
application/src/main/java/org/opentripplanner/transit/model/network/TripPatternBuilder.java
Show resolved
Hide resolved
|
I know you didn't write this code, but can you please apply this commit which tidies the neighbouring code a little bit: leonardehrenfried@e47856b |
leonardehrenfried
approved these changes
Nov 5, 2024
optionsome
approved these changes
Nov 7, 2024
t2gran
pushed a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such geometries may happen when a replacement trip partially uses the original geometry.
Summary
Fix out of bounds under period of train disruption. The problem occurs when fetching geometries for a stop further than the geometry which may happen when a replacement trip partially uses the geometry.
Issue
Fixes #6072 and possibly #3110.
Unit tests
Added.
Documentation
None needed.