Skip to content

Conversation

@miklcct
Copy link
Contributor

@miklcct miklcct commented Oct 17, 2024

Summary

A cable car, in GTFS terminology which uses American English, is a rail vehicle running on street propelled by a cable.
However, in British English, the term "cable car" has a completely separate meaning which has caused confusion,
and the official specification has been updated to use the term "cable tram" as a result.

This changes all references to "cable car" to "cable tram" in the UI code and documentations.
However, it isn't possible to change the name of the enum item without breaking backward compatibility.

Issue

google/transit#186

Unit tests

None, as this is a pure documentation change.

Documentation

Updated

@t2gran
Copy link
Member

t2gran commented Oct 17, 2024

These changes are good, but we do not want the changes in application/src/client/classic-debug. The reason is simply that we do not maintain/support the old ui any more. It is soon going to be deleted from the codebase, so it is waist of time to review it.

The other changes are good!

@t2gran t2gran added this to the 2.7 (next release) milestone Oct 22, 2024
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (440498f) to head (52baf4d).
Report is 71 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6173      +/-   ##
=============================================
- Coverage      69.93%   69.93%   -0.01%     
+ Complexity     17730    17726       -4     
=============================================
  Files           1996     1996              
  Lines          75402    75402              
  Branches        7717     7717              
=============================================
- Hits           52731    52729       -2     
- Misses         19995    19996       +1     
- Partials        2676     2677       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t2gran t2gran merged commit 953e4a4 into opentripplanner:dev-2.x Oct 24, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 24, 2024
@miklcct miklcct deleted the cable_tram_documentation branch October 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants