Skip to content

add stopPositionInPattern in Stoptime in GTFS GraphQL API #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2024
Merged

add stopPositionInPattern in Stoptime in GTFS GraphQL API #6204

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a58ab8
add stopIndex in Stoptime
miklcct Oct 29, 2024
4b8dda8
Merge branch 'dev-2.x' into index-in-stoptime-in-pattern
miklcct Nov 5, 2024
b7d0dbe
rename stopIndex to stopPositionInPattern
miklcct Nov 5, 2024
bb653bc
add integration test for stopPositionInPattern
miklcct Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions application/src/main/java/org/opentripplanner/apis/gtfs/datafetchers/StoptimeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ public DataFetcher<Integer> stopPosition() {
return environment -> getSource(environment).getGtfsSequence();
}

@Override
public DataFetcher<Integer> stopPositionInPattern() {
return environment -> getSource(environment).getStopIndex();
}

@Override
public DataFetcher<Long> serviceDay() {
return environment -> getSource(environment).getServiceDayMidnight();
Expand Down
2 changes: 2 additions & 0 deletions application/src/main/java/org/opentripplanner/apis/gtfs/generated/GraphQLDataFetchers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,8 @@ public interface GraphQLStoptime {

public DataFetcher<Integer> stopPosition();

public DataFetcher<Integer> stopPositionInPattern();

public DataFetcher<Boolean> timepoint();

public DataFetcher<Trip> trip();
Expand Down
13 changes: 11 additions & 2 deletions application/src/main/resources/org/opentripplanner/apis/gtfs/schema.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2195,10 +2195,10 @@ type Stoptime {
"The stop where this arrival/departure happens"
stop: Stop
"""
The sequence of the stop in the pattern. This is not required to start from 0 or be consecutive - any
The sequence of the stop in the trip. This is not required to start from 0 or be consecutive - any
increasing integer sequence along the stops is valid.

The purpose of this field is to identify the stop within the pattern so it can be cross-referenced
The purpose of this field is to identify the stop within the trip so it can be cross-referenced
between it and the itinerary. It is safe to cross-reference when done quickly, i.e. within seconds.
However, it should be noted that real-time updates can change the values, so don't store it for
longer amounts of time.
Expand All @@ -2207,6 +2207,15 @@ type Stoptime {
even generated.
"""
stopPosition: Int
"""
The position of the stop in the pattern. This is required to start from 0 and be consecutive along
the pattern, up to n-1 for a pattern with n stops.

The purpose of this field is to identify the position of the stop within the pattern so it can be
cross-referenced between different trips on the same pattern, as stopPosition can be different
between trips even within the same pattern.
"""
stopPositionInPattern: Int!
"true, if this stop is used as a time equalization stop. false otherwise."
timepoint: Boolean
"Trip which this stoptime is for"
Expand Down
Loading