-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Restore ability to click on stops in debug UI on first map load #6440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore ability to click on stops in debug UI on first map load #6440
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6440 +/- ##
=============================================
- Coverage 69.82% 69.82% -0.01%
+ Complexity 18144 18143 -1
=============================================
Files 2072 2072
Lines 77323 77323
Branches 7841 7841
=============================================
- Hits 53993 53992 -1
Misses 20580 20580
- Partials 2750 2751 +1 ☔ View full report in Codecov by Sentry. |
|
I'm struggling to understand exactly what part of this PR actually makes stops clickable. Can you point me in the right direction? |
Sorry, I should have been more precise: it restores the ability to click on the stops on first page load. I updated the title. At the moment the After this PR the method is called after the map has loaded as well so the right hand panel doesn't need to be rendered for the stops to become clickable. Does this make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the clarifications
Summary
@t2gran asked in today's meeting if it was possible to click on stops in the debug view. This feature existed for a while but was inadvertently broken in #6370 as the stops are not clickable when you first load the map. They only become clickable after opening the right hand panel.
This PR restores it. It seems that I'm the Chief Restorer of Clickable Stops, since this is actually the second time I'm fixing this: #6261
This also removes the animation from the map pan when loading the app.