Skip to content

Conversation

@leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Feb 6, 2025

Summary

@t2gran asked in today's meeting if it was possible to click on stops in the debug view. This feature existed for a while but was inadvertently broken in #6370 as the stops are not clickable when you first load the map. They only become clickable after opening the right hand panel.

This PR restores it. It seems that I'm the Chief Restorer of Clickable Stops, since this is actually the second time I'm fixing this: #6261

This also removes the animation from the map pan when loading the app.

@leonardehrenfried leonardehrenfried added +OTP Debug UI OTP bundled client, the OTP server is normally not changed +Skip Changelog This is not a relevant change for a product owner since last release. labels Feb 6, 2025
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner February 6, 2025 16:27
@leonardehrenfried leonardehrenfried changed the title Restore ability to click on stops on start up Restore ability to click on stops in debug UI Feb 6, 2025
@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.82%. Comparing base (d0aa041) to head (41e4bdb).
Report is 49 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6440      +/-   ##
=============================================
- Coverage      69.82%   69.82%   -0.01%     
+ Complexity     18144    18143       -1     
=============================================
  Files           2072     2072              
  Lines          77323    77323              
  Branches        7841     7841              
=============================================
- Hits           53993    53992       -1     
  Misses         20580    20580              
- Partials        2750     2751       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@testower
Copy link
Contributor

I'm struggling to understand exactly what part of this PR actually makes stops clickable. Can you point me in the right direction?

@leonardehrenfried leonardehrenfried changed the title Restore ability to click on stops in debug UI Restore ability to click on stops in debug UI on first map load Feb 11, 2025
@leonardehrenfried
Copy link
Member Author

I'm struggling to understand exactly what part of this PR actually makes stops clickable. Can you point me in the right direction?

Sorry, I should have been more precise: it restores the ability to click on the stops on first page load. I updated the title.

At the moment the interactiveLayerIds are only set when the right hand panel is rendered the first time. Beforehand they are an empty list.

After this PR the method is called after the map has loaded as well so the right hand panel doesn't need to be rendered for the stops to become clickable.

Does this make sense?

Copy link
Contributor

@testower testower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the clarifications

@leonardehrenfried leonardehrenfried merged commit e692b3e into opentripplanner:dev-2.x Feb 12, 2025
7 checks passed
@leonardehrenfried leonardehrenfried deleted the clickable-debug-stops branch February 12, 2025 06:23
@t2gran t2gran added this to the 2.7 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+OTP Debug UI OTP bundled client, the OTP server is normally not changed +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants