Add generalizedCostMaxLimit field to the PageCursor to enable using RemoveTransitIfStreetOnlyIsBetter filter with paging

[VillePihlava]

Summary

This PR adds the generalizedCostMaxLimit field to the PageCursor. This enables using the RemoveTransitIfStreetOnlyIsBetter filter with paging. Before this PR, this was not possible because paging only used the walk mode to create a direct itinerary which made the filter work incorrectly.

Issue

N/A

Unit tests

Changed existing unit tests for compatibility and created new ones. Also performed manual testing.

Documentation

Code comments, no other documentation

[codecov]

Codecov Report

Attention: Patch coverage is 83.64780% with 26 lines in your changes missing coverage. Please review.

Project coverage is 71.26%. Comparing base (9a5c2aa) to head (ffbc2fd).
Report is 769 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...thm/filterchain/paging/DefaultPageCursorInput.java	83.72%	7 Missing ⚠️
...ain/filters/system/NumItinerariesFilterResult.java	0.00%	6 Missing ⚠️
.../opentripplanner/service/paging/PagingService.java	66.66%	1 Missing and 3 partials ⚠️
...ansit/RemoveTransitIfStreetOnlyIsBetterResult.java	25.00%	3 Missing ⚠️
...m/filterchain/ItineraryListFilterChainBuilder.java	81.81%	2 Missing ⚠️
...rithm/mapping/RouteRequestToFilterChainMapper.java	33.33%	1 Missing and 1 partial ⚠️
...er/model/plan/paging/cursor/PageCursorFactory.java	87.50%	1 Missing ⚠️
...entripplanner/routing/algorithm/RoutingWorker.java	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6474      +/-   ##
=============================================
+ Coverage      70.25%   71.26%   +1.01%     
- Complexity     18385    18486     +101     
=============================================
  Files           2088     2031      -57     
  Lines          77417    76396    -1021     
  Branches        7840     7807      -33     
=============================================
+ Hits           54386    54445      +59     
+ Misses         20262    19190    -1072     
+ Partials        2769     2761       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[VillePihlava]

I removed the direct mode search with paging and refactored bestStreetOnlyCost to streetOnlyCost. This should now be ready-for-review.

[optionsome]

Document whether this is the arrival or departure time of the latest removed departure.

[VillePihlava]

I think because the name has departure in it, it is clear enough, is that ok? The word "arrival" (or an abbreviation) is usually included in variables that deal with arrival times, for example in PageCursorFactory the variable lat (latest arrival time)

[optionsome]

latestRemovedDepartureTime would be slightly more explicit as departure is sometimes a synonym to trip and a trip can be identified by an arrival time.

[VillePihlava]

I think there was a comment here from Thomas that agreed with me, but has now disappeared. Is keeping the name the same ok for you @optionsome

[t2gran]

This still needs structural changes - I will complete my review when these are done. I have not yet looked at the details.

[t2gran]

This still have a dependency to filterchain.

[VillePihlava]

I removed this and modified logic related to null checking in the PageCursorFactory and PagingService. I noticed that the assertRequestPrerequisites function in PagingService is useless because of a preceding check. Should I remove it?

[t2gran]

This looks good now all the architecture comments I had is resolved. There is just a few minor things. When these are fixed I can approve.