Refactor: Separate the Siri TripUpdate into AddedTrip and ModifiedTrip classes #6489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a pure refactor that separates the siri
TripUpdate
object into two different records depending on whether the trip is being modified or if a new trip is being added.The nice thing about having two separate records for
SiriAddTrip
andSiriModifyTrip
is that it's clearer what properties are actually valid depending on the use case, instead of having a big record with lots of nullable fields that is difficult to understand when you can expect different fields to be present or not.Unit tests
There is pretty good test coverage from before of this piece of code.
Bumping the serialization version id
No.