Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for via in access and egress #6501

Draft
wants to merge 4 commits into
base: dev-2.x
Choose a base branch
from
Draft

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Feb 28, 2025

Summary

This feature extends #6477

Issue

Unit tests

Documentation

Changelog

Bumping the serialization version id

@optionsome
Copy link
Member

optionsome commented Mar 3, 2025

My current plan for this is:

  • Only one coordinate per visit location is allowed (internal model currently supports a list of coordinates but I don't think we actually need that ever and it would harm the performance)
  • Access is done as follows (egress follows the same formula, but starts from destination):
    • Direct search is done from origin to first via point, from first to second, etc. until a first via point that is either a via visit with only stop location(s) or it's a pass-through point (for which we don't search a direct route for), or when access duration limit is reached (those direct results that go over the limit are ignored).
    • Search for normal access from origin and from each via visit location that was visited and not ignored by the direct search in the previous bullet. We need to initialize the travel duration based on the direct searches used to reach the via point. The access and egress data that is passed in to raptor contains the "direct travel" that was used to reach the point where the access/egress search begins.
    • No searches are done in parallel by default but we might enable support for it through the ParallelRouting feature.
  • Normal direct modes continue as is after a via visit
  • Parking needs to be done before the first via visit, after that walking
  • Rental vehicle is returned before each via point in access/egress but a vehicle can be re-rented after a via visit
  • Dropoff should happen before the first via visit, walking after it
  • Pickup is done before first via visit in egress, normal car routing after it
  • Flex needs to end before each via visit. Not sure if reusing flex after a via visit should be possible.

@optionsome optionsome force-pushed the via_in_access_egress branch from f001b59 to ef42331 Compare March 10, 2025 14:03
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.18%. Comparing base (94950f1) to head (ef42331).
Report is 3 commits behind head on dev-2.x.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ipplanner/raptor/api/model/RaptorAccessEgress.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6501   +/-   ##
==========================================
  Coverage      70.17%   70.18%           
- Complexity     18312    18314    +2     
==========================================
  Files           2082     2082           
  Lines          77214    77216    +2     
  Branches        7831     7832    +1     
==========================================
+ Hits           54188    54191    +3     
- Misses         20256    20257    +1     
+ Partials        2770     2768    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t2gran t2gran modified the milestones: 2.7, 2.8 (next release) Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants