Skip to content

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Feb 28, 2025

Summary

This feature extends #6477

Issue

Unit tests

Documentation

Changelog

Bumping the serialization version id

@t2gran t2gran added the !New Feature A functional feature targeting the end user. label Feb 28, 2025
@t2gran t2gran added this to the 2.7 (next release) milestone Feb 28, 2025
@optionsome
Copy link
Member

optionsome commented Mar 3, 2025

My current plan for this is:

  • Only one coordinate per visit location is allowed (internal model currently supports a list of coordinates but I don't think we actually need that ever and it would harm the performance)
  • Access is done as follows (egress follows the same formula, but starts from destination):
    • Direct search is done from origin to first via point, from first to second, etc. until a first via point that is either a via visit with only stop location(s) or it's a pass-through point (for which we don't search a direct route for), or when access duration limit is reached (those direct results that go over the limit are ignored).
    • Search for normal access from origin and from each via visit location that was visited and not ignored by the direct search in the previous bullet. We need to initialize the travel duration based on the direct searches used to reach the via point. The access and egress data that is passed in to raptor contains the "direct travel" that was used to reach the point where the access/egress search begins.
    • No searches are done in parallel by default but we might enable support for it through the ParallelRouting feature.
  • Normal direct modes continue as is after a via visit
  • Parking needs to be done before the first via visit, after that walking
  • Rental vehicle is returned before each via point in access/egress but a vehicle can be re-rented after a via visit
  • Dropoff should happen before the first via visit, walking after it
  • Pickup is done before first via visit in egress, normal car routing after it
  • Flex needs to end before each via visit. Not sure if reusing flex after a via visit should be possible.

@optionsome optionsome force-pushed the via_in_access_egress branch from f001b59 to ef42331 Compare March 10, 2025 14:03
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

❌ Patch coverage is 88.12155% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (0fe3e95) to head (16b37ef).
⚠️ Report is 30 commits behind head on dev-2.x.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...entripplanner/routing/algorithm/RoutingWorker.java 73.91% 9 Missing and 3 partials ⚠️
...a/service/DefaultViaCoordinateTransferFactory.java 0.00% 12 Missing ⚠️
...oradapter/transit/mappers/RaptorRequestMapper.java 72.22% 3 Missing and 2 partials ⚠️
...reet/search/TemporaryVerticesContainerBuilder.java 97.36% 1 Missing and 4 partials ⚠️
...rg/opentripplanner/visualizer/GraphVisualizer.java 0.00% 5 Missing ⚠️
...va/org/opentripplanner/apis/gtfs/GraphQLUtils.java 0.00% 2 Missing ⚠️
...ntripplanner/apis/gtfs/generated/GraphQLTypes.java 0.00% 1 Missing ⚠️
...ipplanner/raptor/api/model/RaptorAccessEgress.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6501      +/-   ##
=============================================
+ Coverage      71.76%   71.86%   +0.09%     
- Complexity     19317    19385      +68     
=============================================
  Files           2088     2092       +4     
  Lines          78712    78892     +180     
  Branches        8020     8030      +10     
=============================================
+ Hits           56488    56695     +207     
+ Misses         19367    19343      -24     
+ Partials        2857     2854       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t2gran t2gran modified the milestones: 2.7, 2.8 (next release) Mar 12, 2025
@optionsome optionsome force-pushed the via_in_access_egress branch from 42ba666 to 70d17c5 Compare July 4, 2025 08:41
@optionsome
Copy link
Member

I've rebased this temporarily from #6704

@optionsome optionsome force-pushed the via_in_access_egress branch from 70d17c5 to 57238d9 Compare July 4, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants