Skip to content

Conversation

@Brickblock1
Copy link
Contributor

Summary

Since #6247 it has been possible to link transit data to the streetgraph for linear ways and not just nodes and areas. The list of tags in IsBoardingLocation() was not appropriate for this with regards to buses which use tag highway=platform for linear ways. This PR therefore adds highway=platform to the function.

Issue

Closes #6433

Unit tests

None

Documentation

Docs were updated and now mention both highway=platform and railway=platform in addition to the previous list of tags.

@Brickblock1 Brickblock1 requested a review from a team as a code owner March 1, 2025 17:14
@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (d6c64e6) to head (485c4e5).
Report is 4 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6505   +/-   ##
==========================================
  Coverage      70.13%   70.13%           
- Complexity     18266    18271    +5     
==========================================
  Files           2077     2077           
  Lines          77617    77618    +1     
  Branches        7819     7820    +1     
==========================================
+ Hits           54435    54441    +6     
+ Misses         20402    20400    -2     
+ Partials        2780     2777    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple unit test here:

application/src/test/java/org/opentripplanner/graph_builder/module/osm/moduletests/BoardingLocationTest.java

@Brickblock1 Brickblock1 requested a review from vesameskanen March 2, 2025 13:08
@leonardehrenfried leonardehrenfried added the +Skip Changelog This is not a relevant change for a product owner since last release. label Mar 3, 2025
@leonardehrenfried leonardehrenfried merged commit e0b1758 into opentripplanner:dev-2.x Mar 3, 2025
6 checks passed
@t2gran t2gran added this to the 2.7 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boarding Locations should support more tags

4 participants