TRIAS StopEventRequest#6510
Merged
leonardehrenfried merged 102 commits intoopentripplanner:dev-2.xfrom Jun 5, 2025
Merged
Conversation
f9574c0 to
1bc7f0b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6510 +/- ##
=============================================
+ Coverage 71.40% 71.42% +0.01%
- Complexity 18569 18713 +144
=============================================
Files 2035 2051 +16
Lines 76553 77109 +556
Branches 7824 7842 +18
=============================================
+ Hits 54664 55074 +410
- Misses 19116 19248 +132
- Partials 2773 2787 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1e58323 to
1cc9e74
Compare
298396c to
b881ae2
Compare
0310f4a to
772a2ae
Compare
t2gran
reviewed
May 14, 2025
t2gran
requested changes
May 14, 2025
Member
t2gran
left a comment
There was a problem hiding this comment.
I took a look at the design again - this is not the complete review. I only looked at the src/main code.
...tion/src/main/java/org/opentripplanner/transit/api/request/TripTimeOnDateRequestBuilder.java
Show resolved
Hide resolved
...tion/src/main/java/org/opentripplanner/transit/api/request/TripTimeOnDateRequestBuilder.java
Show resolved
Hide resolved
...ation/src/main/java/org/opentripplanner/standalone/configure/ConstructApplicationModule.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/transit/api/request/TripTimeOnDateRequest.java
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/transit/service/TransitService.java
Show resolved
Hide resolved
eibakke
previously approved these changes
May 22, 2025
Contributor
eibakke
left a comment
There was a problem hiding this comment.
FilterValues usage looks good to me.
t2gran
approved these changes
Jun 5, 2025
eibakke
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements the TRIAS API's
StopEventRequest. This API is used by digital departure boards in the German state of Baden-Württemberg:Implementation
The Java code operates only on OJP data types. TRIAS is the predecessor of OJP and in general very, very similar. Therefore the translation from TRIAS to OJP is done via an XSLT stylesheet which uses the XSLT transformer that is included in Java.
Issue
Closes #6467
Unit tests
Lots added.
Documentation
Sandbox docs.
Bumping the serialization version id
No serialized types change so no bump necessary.
cc @NVBWcho @NVBWSeifert @hbruch