Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIAS StopEventRequest #6510

Open
wants to merge 79 commits into
base: dev-2.x
Choose a base branch
from

Conversation

leonardehrenfried
Copy link
Member

Summary

This implements the TRIAS API's StopEventRequest. This API is used by digital departure boards in the German state of Baden-Württemberg:

image

Implementation

The Java code operates only on OJP data types. TRIAS is the predecessor of OJP and in general very, very similar. Therefore the translation from TRIAS to OJP is done via an XSLT stylesheet which uses the XSLT transformer that is included in Java.

Issue

Closes #6467

Unit tests

Lots added.

Documentation

Sandbox docs.

Bumping the serialization version id

No serialized types change so no bump necessary.

cc @NVBWcho @NVBWSeifert @hbruch

@leonardehrenfried leonardehrenfried force-pushed the trias branch 2 times, most recently from f9574c0 to 1bc7f0b Compare March 4, 2025 16:10
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 74.11348% with 146 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (e969743) to head (88d0b59).
Report is 1 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...g/opentripplanner/ext/ojp/trias/TriasResource.java 0.00% 54 Missing ⚠️
...ntripplanner/ext/ojp/service/OjpServiceMapper.java 64.21% 33 Missing and 1 partial ⚠️
...anner/ext/ojp/mapping/StopEventResponseMapper.java 85.32% 11 Missing and 5 partials ⚠️
.../opentripplanner/ext/ojp/mapping/PtModeMapper.java 53.84% 11 Missing and 1 partial ⚠️
...ipplanner/ext/ojp/trias/OjpToTriasTransformer.java 81.57% 7 Missing ⚠️
...nner/standalone/config/sandbox/TriasApiConfig.java 83.33% 4 Missing and 1 partial ⚠️
...entripplanner/apis/gtfs/datafetchers/StopImpl.java 0.00% 2 Missing ⚠️
...nner/apis/transmodel/model/stop/StopPlaceType.java 0.00% 2 Missing ⚠️
...java/org/opentripplanner/model/TripTimeOnDate.java 90.47% 1 Missing and 1 partial ⚠️
...g/opentripplanner/ext/ojp/mapping/ErrorMapper.java 83.33% 1 Missing ⚠️
... and 11 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6510      +/-   ##
=============================================
+ Coverage      70.99%   71.02%   +0.03%     
- Complexity     18268    18408     +140     
=============================================
  Files           1999     2014      +15     
  Lines          75856    76401     +545     
  Branches        7784     7796      +12     
=============================================
+ Hits           53851    54261     +410     
- Misses         19259    19383     +124     
- Partials        2746     2757      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried leonardehrenfried force-pushed the trias branch 7 times, most recently from 1e58323 to 1cc9e74 Compare March 12, 2025 08:19
@t2gran t2gran added this to the 2.8 (next release) milestone Mar 12, 2025
@leonardehrenfried leonardehrenfried force-pushed the trias branch 15 times, most recently from 298396c to b881ae2 Compare March 14, 2025 15:13
@leonardehrenfried leonardehrenfried marked this pull request as ready for review March 15, 2025 07:01
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner March 15, 2025 07:01
@leonardehrenfried leonardehrenfried force-pushed the trias branch 2 times, most recently from 0310f4a to 772a2ae Compare March 17, 2025 09:06
@leonardehrenfried leonardehrenfried requested review from t2gran and removed request for vpaturet March 31, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement TRIAS API's StopEventRequest
3 participants