Skip to content

Comments

TRIAS StopEventRequest#6510

Merged
leonardehrenfried merged 102 commits intoopentripplanner:dev-2.xfrom
leonardehrenfried:trias
Jun 5, 2025
Merged

TRIAS StopEventRequest#6510
leonardehrenfried merged 102 commits intoopentripplanner:dev-2.xfrom
leonardehrenfried:trias

Conversation

@leonardehrenfried
Copy link
Member

Summary

This implements the TRIAS API's StopEventRequest. This API is used by digital departure boards in the German state of Baden-Württemberg:

image

Implementation

The Java code operates only on OJP data types. TRIAS is the predecessor of OJP and in general very, very similar. Therefore the translation from TRIAS to OJP is done via an XSLT stylesheet which uses the XSLT transformer that is included in Java.

Issue

Closes #6467

Unit tests

Lots added.

Documentation

Sandbox docs.

Bumping the serialization version id

No serialized types change so no bump necessary.

cc @NVBWcho @NVBWSeifert @hbruch

@leonardehrenfried leonardehrenfried force-pushed the trias branch 2 times, most recently from f9574c0 to 1bc7f0b Compare March 4, 2025 16:10
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 72.88732% with 154 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (bb7eba1) to head (f444778).
Report is 108 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...opentripplanner/ext/trias/trias/TriasResource.java 0.00% 54 Missing ⚠️
...ripplanner/ext/trias/service/OjpServiceMapper.java 64.21% 33 Missing and 1 partial ⚠️
...ner/ext/trias/mapping/StopEventResponseMapper.java 85.32% 11 Missing and 5 partials ⚠️
...pentripplanner/ext/trias/mapping/PtModeMapper.java 53.84% 11 Missing and 1 partial ⚠️
.../opentripplanner/ext/trias/service/OjpService.java 81.48% 4 Missing and 6 partials ⚠️
...planner/ext/trias/trias/OjpToTriasTransformer.java 81.57% 7 Missing ⚠️
...anner/ext/trias/parameters/TriasApiParameters.java 50.00% 4 Missing and 1 partial ⚠️
...entripplanner/apis/gtfs/datafetchers/StopImpl.java 0.00% 2 Missing ⚠️
...java/org/opentripplanner/model/TripTimeOnDate.java 90.47% 1 Missing and 1 partial ⚠️
...entripplanner/standalone/server/GrizzlyServer.java 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6510      +/-   ##
=============================================
+ Coverage      71.40%   71.42%   +0.01%     
- Complexity     18569    18713     +144     
=============================================
  Files           2035     2051      +16     
  Lines          76553    77109     +556     
  Branches        7824     7842      +18     
=============================================
+ Hits           54664    55074     +410     
- Misses         19116    19248     +132     
- Partials        2773     2787      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried leonardehrenfried force-pushed the trias branch 7 times, most recently from 1e58323 to 1cc9e74 Compare March 12, 2025 08:19
@t2gran t2gran added this to the 2.8 (next release) milestone Mar 12, 2025
@leonardehrenfried leonardehrenfried force-pushed the trias branch 15 times, most recently from 298396c to b881ae2 Compare March 14, 2025 15:13
@leonardehrenfried leonardehrenfried marked this pull request as ready for review March 15, 2025 07:01
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner March 15, 2025 07:01
@leonardehrenfried leonardehrenfried force-pushed the trias branch 2 times, most recently from 0310f4a to 772a2ae Compare March 17, 2025 09:06
@leonardehrenfried leonardehrenfried requested a review from t2gran May 6, 2025 13:52
@leonardehrenfried leonardehrenfried requested a review from t2gran May 14, 2025 15:50
Copy link
Member

@t2gran t2gran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the design again - this is not the complete review. I only looked at the src/main code.

@leonardehrenfried leonardehrenfried requested a review from t2gran May 20, 2025 09:13
eibakke
eibakke previously approved these changes May 22, 2025
Copy link
Contributor

@eibakke eibakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FilterValues usage looks good to me.

@leonardehrenfried leonardehrenfried merged commit df75016 into opentripplanner:dev-2.x Jun 5, 2025
7 checks passed
@leonardehrenfried leonardehrenfried deleted the trias branch June 5, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user. +Sandbox This will be implemented as a Sandbox feature +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement TRIAS API's StopEventRequest

4 participants