-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRIAS StopEventRequest
#6510
Open
leonardehrenfried
wants to merge
79
commits into
opentripplanner:dev-2.x
Choose a base branch
from
leonardehrenfried:trias
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TRIAS StopEventRequest
#6510
leonardehrenfried
wants to merge
79
commits into
opentripplanner:dev-2.x
from
leonardehrenfried:trias
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9574c0
to
1bc7f0b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6510 +/- ##
=============================================
+ Coverage 70.99% 71.02% +0.03%
- Complexity 18268 18408 +140
=============================================
Files 1999 2014 +15
Lines 75856 76401 +545
Branches 7784 7796 +12
=============================================
+ Hits 53851 54261 +410
- Misses 19259 19383 +124
- Partials 2746 2757 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1e58323
to
1cc9e74
Compare
298396c
to
b881ae2
Compare
0310f4a
to
772a2ae
Compare
c2150bb
to
8762ba7
Compare
eibakke
reviewed
Apr 1, 2025
application/src/main/java/org/opentripplanner/model/TripTimeOnDate.java
Outdated
Show resolved
Hide resolved
eibakke
reviewed
Apr 1, 2025
application/src/main/java/org/opentripplanner/model/TripTimeOnDate.java
Outdated
Show resolved
Hide resolved
eibakke
reviewed
Apr 1, 2025
application/src/main/java/org/opentripplanner/model/TripTimeOnDate.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/transit/api/request/TripTimeOnDateRequest.java
Outdated
Show resolved
Hide resolved
...tion/src/main/java/org/opentripplanner/transit/api/request/TripTimeOnDateRequestBuilder.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements the TRIAS API's
StopEventRequest
. This API is used by digital departure boards in the German state of Baden-Württemberg:Implementation
The Java code operates only on OJP data types. TRIAS is the predecessor of OJP and in general very, very similar. Therefore the translation from TRIAS to OJP is done via an XSLT stylesheet which uses the XSLT transformer that is included in Java.
Issue
Closes #6467
Unit tests
Lots added.
Documentation
Sandbox docs.
Bumping the serialization version id
No serialized types change so no bump necessary.
cc @NVBWcho @NVBWSeifert @hbruch