-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a null-check to the ids argument in the quays Transmodel API endpoint. #6557
base: dev-2.x
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6557 +/- ##
=============================================
- Coverage 70.25% 70.24% -0.02%
+ Complexity 18387 18385 -2
=============================================
Files 2088 2088
Lines 77425 77418 -7
Branches 7843 7842 -1
=============================================
- Hits 54395 54382 -13
- Misses 20258 20267 +9
+ Partials 2772 2769 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation should be changed, it currently says Get all quays
…del API and adds description of requirement that either ids or name must be set.
Summary
This makes the quays API endpoint in the Transmodel API return an error if a null value is passed for the ids argument. This is in line with the behavior today, but today the error happens because the response is too large. Failing early is preferable.
This change also throws an exception when no parameters are set, requiring that either name or ids is set.
Issue
#6543
Unit tests
Tested by running locally. There are no unit tests at this level.