Remove REST API

[VillePihlava]

Summary

This PR removes the REST API and changes some related documentation. This is somewhat related to the ongoing effort to remove the old debug UI in PR #6478.

The snapshot tests require some of the mapping code. This PR preserves this functionality and moves the mapper code to the test scope. Lets discuss in the dev meeting if that is what we want.

Issue

N/A

Unit tests

N/A

Documentation

Files changed:

• doc/user/Configuration.md
• doc/user/apis/Apis.md

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (c418593) to head (6085219).
Report is 97 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...opentripplanner/ext/geocoder/GeocoderResource.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6578      +/-   ##
=============================================
+ Coverage      70.31%   70.97%   +0.65%     
+ Complexity     18403    18236     -167     
=============================================
  Files           2088     1997      -91     
  Lines          77421    75763    -1658     
  Branches        7841     7768      -73     
=============================================
- Hits           54438    53772     -666     
+ Misses         20212    19259     -953     
+ Partials        2771     2732      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[optionsome]

@leonardehrenfried was it that we could also remove the Message_<lang>.properties files now?

[leonardehrenfried]

No, because of this:

OpenTripPlanner/application/src/main/java/org/opentripplanner/apis/gtfs/datafetchers/RoutingErrorImpl.java

Lines 20 to 24 in 89c5a3e

	@Override
	public DataFetcher<String> description() {
	return environment ->
	PlannerErrorMapper.mapMessage(getSource(environment)).message.get(getLocale(environment));
	}

[optionsome]

What should we do about the data overlay feature as I think it was only usable through the REST API. I think @t2gran once mentioned entur might use it for something in the future so maybe we will keep it.

[leonardehrenfried]

A data point about this feature: I emailed the original authors a few weeks ago but never received a response. I suspect they don't work for that company anymore.

[optionsome]

LocationStringParser, QualifiedModeSet, DebugOutput, TransitTimingOutput, GraphQLResponseSerializer, Direction, SnapshotTestBase, SystemErrDebugLogger have some REST API related documentation that should be removed. You should also check if these classes are still needed as whole/at all.

apiProcessingTimeout config parameter doc has reference to the REST API.

BuildConfiguration.md has documentation about Geoid Difference which has a link to a removed rest API class, perhaps the documentation is not relevant anymore? Configuration.md Config version section has a reference to the REST API. Developers-Guide.md has reference to rest API in the release process doc. Version-Comparison.md Routing request parameters section has reference to rest API.

There is a package called org.opentripplanner.routing.algorithm.mapping.restapi

RestAPIPassInDefaultConfigAsJson feature flag can be removed.

[habrahamsson-skanetrafiken]

Good riddance!

[optionsome]

TransitTimingOutput and SystemErrDebugLogger should still be updated.

[leonardehrenfried]

Lets us have a minute's silence after the REST API has gone to the great big JVM in the sky.

REST in peace.