Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astar turn restriction eager blocking fix #6592

Draft
wants to merge 12 commits into
base: dev-2.x
Choose a base branch
from

Conversation

tkalvas
Copy link
Contributor

@tkalvas tkalvas commented Apr 1, 2025

This is pretty terrible to look at, but it accomplices a couple of goals:

  • It does not touch the core AStar/ShortestPathTree code at all
  • The terrible possible looping when isCloseToStartOrEnd returns true is completely removed, leading to improvement in car routing speed
  • Now we find the car route we are looking for

Fixes #6531.

@tkalvas tkalvas requested a review from a team as a code owner April 1, 2025 12:56
@tkalvas tkalvas marked this pull request as draft April 1, 2025 12:57
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.31%. Comparing base (c418593) to head (18adc90).
Report is 80 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...ner/street/search/strategy/DominanceFunctions.java 78.78% 3 Missing and 4 partials ⚠️
...entripplanner/street/search/state/StateEditor.java 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             dev-2.x    #6592    +/-   ##
===========================================
  Coverage      70.31%   70.31%            
- Complexity     18403    18444    +41     
===========================================
  Files           2088     2090     +2     
  Lines          77421    77623   +202     
  Branches        7841     7901    +60     
===========================================
+ Hits           54438    54581   +143     
- Misses         20212    20248    +36     
- Partials        2771     2794    +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Street routing by car sometimes picks very long and slow route
1 participant