Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.graphql-java:graphql-java to v23 #6603

Open
wants to merge 5 commits into
base: dev-2.x
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 7, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.graphql-java:graphql-java 22.3 -> 23.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

graphql-java/graphql-java (com.graphql-java:graphql-java)

v23.0: 23.0

Compare Source

Thanks to everyone for contributing to this release, through pull requests, issues, and discussions!

This is a major release which contains breaking changes.

Key changes

Performance improvements

See all performance improvements on GitHub: https://github.com/graphql-java/graphql-java/issues?q=is%3Amerged%20label%3A%22performance%22%20milestone%3A%2223.0%20breaking%20changes%22%20

Breaking changes

See all breaking changes on GitHub: https://github.com/graphql-java/graphql-java/issues?q=is%3Amerged%20label%3A%22breaking%20change%22%20milestone%3A%2223.0%20breaking%20changes%22

Security

We have become a CVE Numbering Authority (CNA) for GraphQL Java and related projects. For more information, see our Security page https://www.graphql-java.com/security.

What's Changed

New Contributors

Full Changelog: graphql-java/graphql-java@v22.3...v23.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner April 7, 2025 02:21
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.98%. Comparing base (502b96b) to head (b6442bb).
Report is 11 commits behind head on dev-2.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6603      +/-   ##
=============================================
- Coverage      70.99%   70.98%   -0.01%     
- Complexity     18269    18272       +3     
=============================================
  Files           1999     2000       +1     
  Lines          75856    75872      +16     
  Branches        7784     7785       +1     
=============================================
+ Hits           53851    53856       +5     
- Misses         19260    19269       +9     
- Partials        2745     2747       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@optionsome
Copy link
Member

I can take a look at this to fix the issues.

This recent scec change had to be manually updated since the GraphQLFormattingTest doesn't update existing directives seemingly
@optionsome
Copy link
Member

optionsome commented Apr 9, 2025

Schema validation test fails due to @deprecated directive's reason field being required now. We always include the field so this shouldn't cause any problems.

Copy link
Contributor Author

renovate bot commented Apr 9, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but the CI job says there is a breaking change. Is adding an making the input to an annotation really a breaking change? I don't think so.

@optionsome
Copy link
Member

This looks good but the CI job says there is a breaking change. Is adding an making the input to an annotation really a breaking change. I don't think so.

Yep, it sort of feels like a bug in the validation library that it complains about a directive. The directive usage is on the schema side, API users can't use it.

@optionsome
Copy link
Member

optionsome commented Apr 11, 2025

I've opened #6612 to fix the issue that we don't get validation report on the second schema if the first one has a breaking change. Usually it doesn't matter, but seems like sometimes we do make changes to both schemas at once and even "breaking" changes. https://github.com/opentripplanner/OpenTripPlanner/actions/runs/14405863905/job/40402118988 shows the output of this pr with the workflow fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants