Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase values in getMaxSpeedForMode #6606

Open
wants to merge 1 commit into
base: dev-2.x
Choose a base branch
from

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Apr 7, 2025

Summary

The maximum speed to validate stop times (where issue reports are generated) is increased for SUBWAY and RAIL modes to reflect latest technological advances.

For example, the Beijing - Shanghai high speed train now averages over 300 km/h throughout its journey, and now Guangzhou has metro lines of 160 km/h running speed.

Issue

None

Unit tests

None

Documentation

N/A

Changelog

Not needed

Bumping the serialization version id

Not needed

@miklcct miklcct marked this pull request as ready for review April 7, 2025 15:11
@miklcct miklcct requested a review from a team as a code owner April 7, 2025 15:11
@optionsome optionsome requested review from optionsome and abyrd April 8, 2025 09:26
@optionsome
Copy link
Member

Btw @miklcct, do you have data sets where you run into this problem? I'm not personally against this type of a change even if you aren't facing the issue of now but this information could still be useful when we make the decision on if we should change these limits. Also, what does "running speed" mean? Is it the maximum speed or some average that takes into account slowing down, acceleration and opening/closing doors? Metro stops aren't typically that far apart so those do affect the average a bit.

@miklcct
Copy link
Contributor Author

miklcct commented Apr 10, 2025

Btw @miklcct, do you have data sets where you run into this problem? I'm not personally against this type of a change even if you aren't facing the issue of now but this information could still be useful when we make the decision on if we should change these limits. Also, what does "running speed" mean? Is it the maximum speed or some average that takes into account slowing down, acceleration and opening/closing doors? Metro stops aren't typically that far apart so those do affect the average a bit.

This problem hasn't been encountered in GB yet (as the maximum train speed is 225 km/h) but it may be of interest in some other countries with faster high speed trains.

The 160 km/h on metro trains refer to the maximum line and train speed. However, with skip-stopping metro services, the current limit in OTP can be exceeded on those lines. The Guangzhou Metro line 18 has a 25.8 km non-stop section between Panyu and the city, so the limit is exceeded with 160 km/h running for such a long distance. It is called a high-speed metro because it is built to higher-speed rail standard, but it is regulated and operated as a metro service inside the metro network.

@miklcct
Copy link
Contributor Author

miklcct commented Apr 10, 2025

The GTFS validator uses the following values:

Route type Description Threshold, km/h
0 Light rail 100
1 Subway 150
2 Rail 500
3 Bus 150
4 Ferry 80
5 Cable tram 30
6 Aerial lift 50
7 Funicular 50
11 Trolleybus 150
12 Monorail 150

  • Unknown 200

Should we do the same in OTP as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants