Skip to content

Turn restriction graph application #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: dev-2.x
Choose a base branch
from

Conversation

tkalvas
Copy link
Contributor

@tkalvas tkalvas commented Apr 11, 2025

Summary

Do not block intersections with turn restrictions too eagerly when first reaching them from a bad direction.

Fixes #6531

Will make unnecessary to support StreetEdge.turnRestrictions at route time at all, speeding up routing.

Unit tests

There's a test for application of turn restrictions right next to each other which is run in both orders, because it is the situation with most potential for bad logic.

Changelog

The fixed bug is potentially very visible, so this should go to changelog.

Bumping the serialization version id

Yes.

This is a significant change in the graph building.

@tkalvas tkalvas requested a review from a team as a code owner April 11, 2025 13:33
@tkalvas tkalvas marked this pull request as draft April 11, 2025 13:33
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.03%. Comparing base (eec3168) to head (368a832).
Report is 58 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...er/graph_builder/module/TurnRestrictionModule.java 68.42% 15 Missing and 9 partials ⚠️
...rg/opentripplanner/graph_builder/GraphBuilder.java 0.00% 1 Missing ⚠️
..._builder/module/configure/GraphBuilderModules.java 0.00% 1 Missing ⚠️
...anner/street/model/vertex/SubsidiaryOsmVertex.java 90.90% 1 Missing ⚠️
...entripplanner/street/model/vertex/VertexLabel.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6611      +/-   ##
=============================================
+ Coverage      70.99%   71.03%   +0.04%     
- Complexity     18271    18318      +47     
=============================================
  Files           2000     2007       +7     
  Lines          75863    75940      +77     
  Branches        7784     7794      +10     
=============================================
+ Hits           53856    53947      +91     
+ Misses         19262    19240      -22     
- Partials        2745     2753       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Street routing by car sometimes picks very long and slow route
1 participant