-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suport for importing CO₂ emission per trip leg #6614
Open
t2gran
wants to merge
43
commits into
opentripplanner:dev-2.x
Choose a base branch
from
entur:add_co2_emissions
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This need a follow-up commit to make the code compile
This test should not need to know about the emission module, a simple teest that ensure the emission decorator is called can be done whit a mock object.
dc2af3a
to
ce25780
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6614 +/- ##
=============================================
+ Coverage 71.03% 71.15% +0.11%
- Complexity 18296 18436 +140
=============================================
Files 2005 2024 +19
Lines 75849 76171 +322
Branches 7779 7790 +11
=============================================
+ Hits 53882 54196 +314
- Misses 19222 19229 +7
- Partials 2745 2746 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
Config Change
Entur Test
This is currently being tested at Entur
Entur
On Entur Roadmap
New Feature
Sandbox
Skip Changelog
Technical Debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add support for importing emissions on trip leg. The emissions.txt CSV input format looks like this:
The plan is to add support for TripOnServiceDay later. This input format put the entire emission calculation
responsibility on the producer of the input. OTP only decorate itinerary legs by adding the trips "legs" used.
This Transmodel API is NOT updated, this will be done in a separate PR.
Some notes:
Emission
was (Co2Emissions
).emissions
(plural) is replaced withemission
(singular) in calss, variable and package names following the code convention. A few places is left where the emission variable was indeed more than oneEmission
(array ofEmission
s). The user and JavaDoc is updated, but the plural is kept where it is natural.Emissions
.emission
, notemissions
in build-config.json.Agency.feed
+Route.id.id
to use justRoute.id
. I guess this was a mistake? (DefaultEmissionService
line 33)Issue
I have not tested, but it should fix #6609
Unit tests
✅ The emission module now have close to 100% branch coverage, I have also added unit-tests on the old code - witch had poor and missing test coverage.
Documentation
🟥 I have not added use documentation yet.
Changelog
🟥 This is a Sandbox featue, I will add user doc/changelog in a later PR.
Bumping the serialization version id
✅ The serialization is changed.