-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Carpooling POC #6791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
t2gran
wants to merge
10
commits into
opentripplanner:dev-2.x
Choose a base branch
from
entur:carpooling_pok
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Carpooling POC #6791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6791 +/- ##
=============================================
- Coverage 72.18% 71.78% -0.41%
- Complexity 19840 20007 +167
=============================================
Files 2155 2182 +27
Lines 80051 81158 +1107
Branches 8082 8197 +115
=============================================
+ Hits 57786 58257 +471
- Misses 19419 20039 +620
- Partials 2846 2862 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7ef5e89 to
79de33f
Compare
ba29af0 to
800d5a3
Compare
0a24110 to
7067369
Compare
…dimentary search. Next I want to implement actual A* functionality.
…up the CarpoolingRepository a bit.
… heuristic to improve performance.
7067369 to
408397a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
!New Feature
A functional feature targeting the end user.
+Sandbox
This will be implemented as a Sandbox feature
+Skip Changelog
This is not a relevant change for a product owner since last release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for carpooling using Siri ET updates and a carpooling service using AStar.
This is a Proof Of Concept(POC), hence developed as a Sandbox feature. Changes to the Siri standard is needed to make this work. We will work with the standardisation in parallel with the software development. The development is expected to take at least one year.
Issue
Part of #6604
Unit tests
TODO
Documentation
TODO
Changelog
TODO
Bumping the serialization version id
If you have made changes to the way the routing graph is serialized, for example by renaming a field
in one of the edges, then you must add the label
bump serialization idto the PR. With this labelGithub Actions will increase the field
otp.serialization.version.idinpom.xml.