Skip to content

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Aug 8, 2025

Summary

Add support for carpooling using Siri ET updates and a carpooling service using AStar.

This is a Proof Of Concept(POC), hence developed as a Sandbox feature. Changes to the Siri standard is needed to make this work. We will work with the standardisation in parallel with the software development. The development is expected to take at least one year.

Issue

Part of #6604

Unit tests

TODO

Documentation

TODO

Changelog

TODO

Bumping the serialization version id

If you have made changes to the way the routing graph is serialized, for example by renaming a field
in one of the edges, then you must add the label bump serialization id to the PR. With this label
Github Actions will increase the field otp.serialization.version.id in pom.xml.

@t2gran t2gran requested a review from a team as a code owner August 8, 2025 10:57
@t2gran t2gran added !New Feature A functional feature targeting the end user. +Sandbox This will be implemented as a Sandbox feature Entur Test This is currently being tested at Entur +Skip Changelog This is not a relevant change for a product owner since last release. labels Aug 8, 2025
@t2gran t2gran marked this pull request as draft August 8, 2025 10:58
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 42.01077% with 646 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.78%. Comparing base (e9e4dff) to head (408397a).
⚠️ Report is 4 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...nner/ext/carpooling/updater/CarpoolSiriMapper.java 0.00% 153 Missing ⚠️
...entripplanner/ext/carpooling/model/CarpoolLeg.java 0.00% 96 Missing ⚠️
...t/carpooling/service/DefaultCarpoolingService.java 0.00% 67 Missing ⚠️
...xt/carpooling/updater/SiriETCarpoolingUpdater.java 0.00% 50 Missing ⚠️
...lanner/ext/carpooling/model/CarpoolLegBuilder.java 0.00% 41 Missing ⚠️
...ntripplanner/ext/carpooling/model/CarpoolStop.java 25.92% 40 Missing ⚠️
...xt/carpooling/internal/CarpoolItineraryMapper.java 0.00% 37 Missing ⚠️
...config/updaters/SiriETCarpoolingUpdaterConfig.java 0.00% 34 Missing ⚠️
...anner/ext/carpooling/model/CarpoolTripBuilder.java 58.18% 22 Missing and 1 partial ⚠️
...er/ext/carpooling/routing/CarpoolStreetRouter.java 33.33% 20 Missing ⚠️
... and 18 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6791      +/-   ##
=============================================
- Coverage      72.18%   71.78%   -0.41%     
- Complexity     19840    20007     +167     
=============================================
  Files           2155     2182      +27     
  Lines          80051    81158    +1107     
  Branches        8082     8197     +115     
=============================================
+ Hits           57786    58257     +471     
- Misses         19419    20039     +620     
- Partials        2846     2862      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t2gran t2gran added this to the 2.8 (next release) milestone Aug 11, 2025
@vpaturet vpaturet removed the Entur Test This is currently being tested at Entur label Aug 13, 2025
@eibakke eibakke added the Entur Test This is currently being tested at Entur label Aug 19, 2025
@t2gran t2gran removed the Entur Test This is currently being tested at Entur label Aug 19, 2025
@eibakke eibakke added Entur Test This is currently being tested at Entur and removed Entur Test This is currently being tested at Entur labels Aug 20, 2025
@optionsome optionsome changed the title Carpooling POK Carpooling POC Sep 2, 2025
@t2gran t2gran modified the milestones: 2.8, 2.9 (next release) Sep 10, 2025
@eibakke eibakke added the Entur Test This is currently being tested at Entur label Sep 11, 2025
@t2gran t2gran added Entur Test This is currently being tested at Entur and removed Entur Test This is currently being tested at Entur labels Sep 11, 2025
@t2gran t2gran removed the Entur Test This is currently being tested at Entur label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user. +Sandbox This will be implemented as a Sandbox feature +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants