Simplify equals in TripPatternForDate

[vpaturet]

Summary

Follow-up after #6868:
This PR simplifies the equals() method in TripPatternForDate to align it on the hashcode method.
The natural key of a TripPatternForDate is the pair (routing trip pattern id, service date)

Issue

Relates to #6820

Unit tests

No

Documentation

Updated Javadoc

Changelog

skip

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.10%. Comparing base (3e501b2) to head (c9d451c).
⚠️ Report is 373 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...ithm/raptoradapter/transit/TripPatternForDate.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #6883   +/-   ##
==========================================
  Coverage      72.10%   72.10%           
+ Complexity     19540    19537    -3     
==========================================
  Files           2106     2106           
  Lines          79004    79000    -4     
  Branches        8009     8006    -3     
==========================================
- Hits           56967    56965    -2     
+ Misses         19217    19214    -3     
- Partials        2820     2821    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[leonardehrenfried]

Vincent will test this before merging.

[leonardehrenfried]

The code looks good and it sounds like the correct thing to do, but this is a very tricky area of the code base, which was subtly broken by changes like this before, so we need to be extra-careful testing this.