Skip to content

Conversation

hjvuor
Copy link

@hjvuor hjvuor commented Oct 3, 2025

Summary

In the current debug ui there is no way to choose which property is opened if they are on top of eachother.
This PR adds a map popup that opens if the user clicks where there are multiple overlapping map features.
The popup displays a list of overlapping features that the user can select from.

There may be multiple situations where this behavior could be useful, including the debugging of elevators where the vertices are directly on top of each other.

Issue

Related to improving indoor navigation Issue #6829

image

@hjvuor hjvuor requested a review from a team as a code owner October 3, 2025 10:58
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.10%. Comparing base (4ab91e2) to head (a482f75).
⚠️ Report is 37 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6928   +/-   ##
==========================================
  Coverage      72.10%   72.10%           
- Complexity     19659    19665    +6     
==========================================
  Files           2124     2125    +1     
  Lines          79507    79522   +15     
  Branches        8050     8049    -1     
==========================================
+ Hits           57325    57341   +16     
+ Misses         19345    19344    -1     
  Partials        2837     2837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried
Copy link
Member

Can we see some screenshots?

@VillePihlava
Copy link
Contributor

Can you sort the list so that, for example, OsmVertexOnLevel objects are one after the other. Also, if it is possible, seeing the level of the object in the FeatureSelectPopup would be nice. You could also sort based on that

@hjvuor
Copy link
Author

hjvuor commented Oct 3, 2025

Can you sort the list so that, for example, OsmVertexOnLevel objects are one after the other. Also, if it is possible, seeing the level of the object in the FeatureSelectPopup would be nice. You could also sort based on that

Displaying the attributes of the objects is problematic since not all have the same set of attributes and for example level is often not present. It would make perfect sense in the case of elevators but then what attributes do we display elsewhere?

@VillePihlava
Copy link
Contributor

VillePihlava commented Oct 3, 2025

Displaying the attributes of the objects is problematic since not all have the same set of attributes and for example level is often not present. It would make perfect sense in the case of elevators but then what attributes do we display elsewhere?

For those objects that have a level, display it (taking into account that in the future edges can have 2 levels), if no level info is present, display something like N/A.

So for example:

Graph objects Level(s)
footbridge (generated) N/A
OsmVertexOnLevel 0
MultiLevelEdge 1, 2

Otherwise I think a short summary of the graph objects would make sense. The summary could include levelinfo, osmid, etc.

@testower
Copy link
Contributor

testower commented Oct 3, 2025

I think we should be careful about showing additional attributes, as @hjvuor not all have the same attributes, and how do we decide which attributes are important enough across all object types?

@VillePihlava
Copy link
Contributor

VillePihlava commented Oct 3, 2025

I think we should be careful about showing additional attributes, as @hjvuor not all have the same attributes, and how do we decide which attributes are important enough across all object types?

This is a good point. I still think that the main use case for this is vertices/edges that are on top of each other. This is true for vertices used by elevators, for example. In that case, seeing the level info is very useful

@optionsome
Copy link
Member

Are the things in the list already sorted by the level or are they in random order? Could we sort them by level?

@t2gran
Copy link
Member

t2gran commented Oct 8, 2025

The reason for displaying extra attributes would be to let the user identify items, and tell them apart form other elements with the same type in the list. If the sorting order is deterministic and clearly defined then that would serve the same purpose.

@habrahamsson-skanetrafiken habrahamsson-skanetrafiken marked this pull request as draft October 16, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants