-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a map popup to select from multiple features if they are overlapping #6928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.x
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6928 +/- ##
==========================================
Coverage 72.10% 72.10%
- Complexity 19659 19665 +6
==========================================
Files 2124 2125 +1
Lines 79507 79522 +15
Branches 8050 8049 -1
==========================================
+ Hits 57325 57341 +16
+ Misses 19345 19344 -1
Partials 2837 2837 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Can we see some screenshots? |
Can you sort the list so that, for example, |
Displaying the attributes of the objects is problematic since not all have the same set of attributes and for example level is often not present. It would make perfect sense in the case of elevators but then what attributes do we display elsewhere? |
For those objects that have a level, display it (taking into account that in the future edges can have 2 levels), if no level info is present, display something like So for example:
Otherwise I think a short summary of the graph objects would make sense. The summary could include levelinfo, osmid, etc. |
I think we should be careful about showing additional attributes, as @hjvuor not all have the same attributes, and how do we decide which attributes are important enough across all object types? |
This is a good point. I still think that the main use case for this is vertices/edges that are on top of each other. This is true for vertices used by elevators, for example. In that case, seeing the level info is very useful |
Are the things in the list already sorted by the level or are they in random order? Could we sort them by level? |
The reason for displaying extra attributes would be to let the user identify items, and tell them apart form other elements with the same type in the list. If the sorting order is deterministic and clearly defined then that would serve the same purpose. |
Summary
In the current debug ui there is no way to choose which property is opened if they are on top of eachother.
This PR adds a map popup that opens if the user clicks where there are multiple overlapping map features.
The popup displays a list of overlapping features that the user can select from.
There may be multiple situations where this behavior could be useful, including the debugging of elevators where the vertices are directly on top of each other.
Issue
Related to improving indoor navigation Issue #6829